Skip to content

Conversation

@eeberhard
Copy link
Member

@eeberhard eeberhard commented Dec 18, 2025

Description

In #405, I added database entries for hardware, but unfortunately didn't check the typescript type generation using this approach. The mutually exclusive conditional requirements lead to unknown properties.

In the original PR I had mentioned two options, and didn't have a strong preference for either so just chose one:

Currently, I have a oneOf condition that requires either urdf (string) or the new database_entry (object) property. I could also have done it so that the single required urdf property is oneOf string or object. Please let me know your preference.

Now I have a strong preference for the second case!

Review guidelines

Estimated Time of Review: 2 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@eeberhard eeberhard requested a review from domire8 December 18, 2025 07:38
@eeberhard eeberhard merged commit 4ace203 into main Dec 21, 2025
1 check passed
@eeberhard eeberhard deleted the fix/schema/application-hardware-database branch December 21, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants