Skip to content

feat: migrate communication interfaces#190

Merged
domire8 merged 5 commits intomainfrom
feat/comm-interfaces
May 6, 2024
Merged

feat: migrate communication interfaces#190
domire8 merged 5 commits intomainfrom
feat/comm-interfaces

Conversation

@domire8
Copy link
Copy Markdown
Member

@domire8 domire8 commented May 1, 2024

Description

Review by commit: First commit, I added (without changes, except the CMakeLists.txt) all sources from communication libraries. Second commit, I updated all necessary existing files to account for a new module in the build system.

We can either merge this and check the rolling image across the stack or i can make some local builds and test it this way.

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8 domire8 requested review from LouisBrunner and eeberhard May 1, 2024 06:49
Comment thread python/setup.py Outdated
@domire8
Copy link
Copy Markdown
Member Author

domire8 commented May 1, 2024

This seems to link the libraries correctly, tested with the ZMQ lightweight interface in HC. If we merge this, it will release a new version 8.1.0

Copy link
Copy Markdown
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This has been something we have discussed for a while and I think it's well worth it.

This will essentially deprecate https://github.com/aica-technology/network-interfaces once downstream users switch to v8.1.

@domire8 domire8 merged commit 06f9070 into main May 6, 2024
@domire8 domire8 deleted the feat/comm-interfaces branch May 6, 2024 05:20
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants