Skip to content

fix: revert ABI breaking addition of assignments in C++#239

Merged
domire8 merged 2 commits intomainfrom
revert/assignments
Apr 8, 2026
Merged

fix: revert ABI breaking addition of assignments in C++#239
domire8 merged 2 commits intomainfrom
revert/assignments

Conversation

@domire8
Copy link
Copy Markdown
Member

@domire8 domire8 commented Apr 2, 2026

Description

As described, this PR will just fast forward the commits without squashing

Review guidelines

Estimated Time of Review: 10 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

Related issues

Blocked by:

@domire8 domire8 force-pushed the revert/assignments branch from 04d5189 to 271c9cb Compare April 2, 2026 13:34
@domire8 domire8 linked an issue Apr 2, 2026 that may be closed by this pull request
@domire8 domire8 force-pushed the revert/assignments branch from 271c9cb to 894b828 Compare April 2, 2026 14:01
@domire8 domire8 requested a review from SprGrf April 2, 2026 14:01
@domire8 domire8 marked this pull request as ready for review April 2, 2026 14:01
@domire8 domire8 requested a review from eeberhard as a code owner April 2, 2026 14:01
@domire8 domire8 force-pushed the revert/assignments branch from 894b828 to a307107 Compare April 2, 2026 14:17
SprGrf
SprGrf previously approved these changes Apr 2, 2026
Copy link
Copy Markdown

@SprGrf SprGrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me. I would add the reason why are reverting in the changelog for transparency.

Copy link
Copy Markdown
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR will just fast forward the commits without squashing

I think it defeats the purpose of fastforwarding these changes if you've made any changes to the revert commits (the typos in Predicate, and the changelog). I would prefer to squash this, as is, into one revert commit which has the two revert messages in the commit body plus the additional changes made as another entry in the commit body.

Or else, if you want to fast-forward, keep the first two as pure revert commits and add a third chore commit that touches up the typos and changelog, but that means rewriting this branch again

@domire8
Copy link
Copy Markdown
Member Author

domire8 commented Apr 7, 2026

Ok so if I squash this PR, then #241 is not blocking this anymore. Initially, I wanted to put another commit onto this branch and then fast forward the 3 revert commits.

Given your feedback, I can squash this PR as one commit and then #241 becomes a separate commit on main.?

@domire8 domire8 changed the title Revert ABI breaking addition of assignments in C++ fix: revert ABI breaking addition of assignments in C++ Apr 7, 2026
@domire8 domire8 merged commit bd32dbb into main Apr 8, 2026
4 checks passed
@domire8 domire8 deleted the revert/assignments branch April 8, 2026 07:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert ABI breaking changes from modulo v5.4

3 participants