feat(ci): add an automated build for network-interfaces that can be copied into a ros2-modulo-control image#39
Merged
LouisBrunner merged 3 commits intodevelopfrom May 30, 2023
Merged
Conversation
…opied into a ros2-modulo-control image
domire8
approved these changes
May 24, 2023
| @@ -0,0 +1,19 @@ | |||
| cmake_minimum_required(VERSION 3.15) | |||
Member
There was a problem hiding this comment.
If you want, you can for now just focus on the network_interfaces. communication_interfaces is meant to replace it, but I'm not there yet. So technically, they are not meant to coexist. But up to you
Contributor
Author
There was a problem hiding this comment.
It isn't much effort to support both and I think it makes sense if communication_interfaces is the future.
eeberhard
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #38
Example build: https://github.com/aica-technology/network-interfaces/actions/runs/5059684431/jobs/9081636211
COPY --from=net-iface / /to install zmq, network-interfaces, communication-interfaces, etc which is convenient for build and production imagesdynamic-componentsto snapshot apt packages to keep only what needs to be installedReview guidelines
Estimated Time of Review: 7 minutes
Related issues
Blocks:
hardware-collection PR