feat(computing-unit): add per-computing-unit dataset mount API#8
Closed
aicam wants to merge 1 commit into
Closed
Conversation
Let users mount versioned datasets onto a specific computing unit,
independent of any workflow. The node mounter gains GET /mounts and
DELETE /mount so a CU's mounts can be listed and unmounted individually,
and the computing-unit service exposes GET/POST/DELETE
/computing-unit/{cuid}/mounts, forwarding to that CU's node mounter via a
new MounterClient. Dataset paths resolve to repository/commit through
FileResolver, which gains a reverse resolver so mounts can be shown with
their human-readable dataset path. Purely additive.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01H27sHgS29u2JcLYPPR6Hdx
Automated Reviewer SuggestionsBased on the
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 365 | 0.223 | 26,610/45,550/45,550 us | 🔴 +20.4% / ⚪ within ±5% |
| 🔴 | bs=100 sw=10 sl=64 | 802 | 0.489 | 123,509/148,981/148,981 us | 🔴 +5.5% / ⚪ within ±5% |
| ⚪ | bs=1000 sw=10 sl=64 | 911 | 0.556 | 1,094,336/1,155,758/1,155,758 us | ⚪ within ±5% / ⚪ within ±5% |
Baseline details
Latest main 9602949 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 365 tuples/sec | 397 tuples/sec | n/a | -8.1% | n/a |
| bs=10 sw=10 sl=64 | MB/s | 0.223 MB/s | 0.243 MB/s | n/a | -8.2% | n/a |
| bs=10 sw=10 sl=64 | p50 | 26,610 us | 22,431 us | n/a | +18.6% | n/a |
| bs=10 sw=10 sl=64 | p95 | 45,550 us | 37,839 us | n/a | +20.4% | n/a |
| bs=10 sw=10 sl=64 | p99 | 45,550 us | 37,839 us | n/a | +20.4% | n/a |
| bs=100 sw=10 sl=64 | throughput | 802 tuples/sec | 808 tuples/sec | n/a | -0.7% | n/a |
| bs=100 sw=10 sl=64 | MB/s | 0.489 MB/s | 0.493 MB/s | n/a | -0.8% | n/a |
| bs=100 sw=10 sl=64 | p50 | 123,509 us | 121,058 us | n/a | +2.0% | n/a |
| bs=100 sw=10 sl=64 | p95 | 148,981 us | 141,180 us | n/a | +5.5% | n/a |
| bs=100 sw=10 sl=64 | p99 | 148,981 us | 141,180 us | n/a | +5.5% | n/a |
| bs=1000 sw=10 sl=64 | throughput | 911 tuples/sec | 921 tuples/sec | n/a | -1.1% | n/a |
| bs=1000 sw=10 sl=64 | MB/s | 0.556 MB/s | 0.562 MB/s | n/a | -1.1% | n/a |
| bs=1000 sw=10 sl=64 | p50 | 1,094,336 us | 1,077,196 us | n/a | +1.6% | n/a |
| bs=1000 sw=10 sl=64 | p95 | 1,155,758 us | 1,140,117 us | n/a | +1.4% | n/a |
| bs=1000 sw=10 sl=64 | p99 | 1,155,758 us | 1,140,117 us | n/a | +1.4% | n/a |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,547.65,200,128000,365,0.223,26610.06,45549.56,45549.56
1,100,10,64,20,2494.54,2000,1280000,802,0.489,123508.59,148981.40,148981.40
2,1000,10,64,20,21961.21,20000,12800000,911,0.556,1094335.55,1155758.17,1155758.17
Owner
Author
|
Superseded — this feature is now being contributed directly to apache/texera:main as two balanced PRs: apache#6866 (out-of-pod mount infrastructure) and apache#6867 (platform mount integration), tracked in apache#6606. Closing this fork-staging PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Add a backend API to mount, list, and unmount dataset versions on a specific computing unit, independent of any workflow. The computing-unit service acts as an authenticated, stateless proxy to that CU's node
texera-mounter— mount state lives only on the mounter (the kernel mount table), so nothing is persisted here.bin/mounter/mounter.py) —GET /mounts?cuid=lists a CU's current mounts (from/proc/mounts);DELETE /mountunmounts a single dataset (distinct from the pod-death reaper).ComputingUnitManagingResource) —GET/POST/DELETE /computing-unit/{cuid}/mounts.POSTresolves/ownerEmail/datasetName/versionName→repository:commitHash, finds the CU pod's node IP, and forwards to that node's mounter with a freshly minted per-user JWT (authorization stays in file-service). A smallMounterClientspeaks HTTP to the mounter.FileResolver) —repository:commitHash→/ownerEmail/datasetName/versionName, so listed mounts show a human-readable path.Purely additive — no existing endpoint, schema, or runtime path changes. This is the control-plane foundation for the "Mount datasets into computing unit" UI (follow-up).
Any related issues, documentation, discussions?
Implements apache#6862 · part of apache#6606. Stacks on apache#6608 (mount infrastructure).
How was this PR tested?
Compiled (
ComputingUnitManagingService/compile) and validated end-to-end on a single-node minikube: created an 8Gi Kubernetes computing unit,POST /computing-unit/{cuid}/mountsreturned 200 with the host mount path,GET /mountslisted it with the reverse-resolved dataset path, andDELETEunmounted it (empty list after). The mounted dataset was then read bit-exact by a Python UDF (a ~2 GB sharded PyTorch model,torch.loadfrom the mounted path).Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.8