feat(action): add configurable no-adapter strictness - #73
Merged
Conversation
limaronaldo
commented
Jul 24, 2026
limaronaldo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Semantic verdict: PASS
Review checklist:
-
strictdefaults fail-closed - only explicit
strict: falsesuppresses the no-adapter discovery condition - invalid configuration and other scan errors remain blocking
- scanner exit code 2 remains exposed even when the action check is non-blocking
- generated workflows retain safe
strict: truebehavior - no breaking change to the public Rust
CiInstallOptionsAPI - composite-action E2E covers permissive, strict, and genuine-error paths
- docs match implemented semantics
No blocking findings in the remote patch. Merge remains gated on the new-head CI, especially both Action E2E platforms.
limaronaldo
marked this pull request as ready for review
July 24, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strictGitHub Action input, defaulting totruestrict: falseto make no-adapter discovery errors non-blockingstrict: truefrom generated CI workflows without changing the public Rust APIWhy
Repositories that intentionally scan mixed trees may have paths with no supported AgentShield adapter. They need an explicit opt-out for that discovery condition without accidentally suppressing real scanner failures.
Verification
cargo fmt --all --checkcargo check --workspace --all-targets --lockedcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --all-targets --locked— 422 passedactionlintdocs/harness/bin/sensors.sh— green