Skip to content

Fix current branch CI - #983

Merged
adriandemian merged 2 commits into
ralphx/ralphx/agent-ef006d8bfrom
ralphx/ralphx/agent-e643ef62
Aug 4, 2026
Merged

Fix current branch CI#983
adriandemian merged 2 commits into
ralphx/ralphx/agent-ef006d8bfrom
ralphx/ralphx/agent-e643ef62

Conversation

@adriandemian

@adriandemian adriandemian commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Update test assertions to match the current queue recovery behavior when AgentRun persistence fails during queued continuation processing. The message is now restored to the queue front instead of being consumed. Also simplify the publish-grace boolean for readability.

User Impact

No user-facing impact; test alignment and code simplification only.

Technical Context

When AgentRun persistence fails during a queued continuation, the production code now restores the message to the queue front, decrements total_processed, and does not report a new last_run_id. The test queue_processing_stops_before_launch_when_run_persistence_fails was asserting the prior contract.

This PR updates three assertions to reflect the current behavior:

  • total_processed == 0 (failed run does not count as processed)
  • last_run_id.is_none() (no run was persisted)
  • New assertion: message is restored to the queue (length remains 1)

Existing assertions (no run_started event, queue slot release) remain valid under the new contract.

Secondary change: simplify scheduler.rs boolean condition from !elapsed_since(...).is_some_and(|elapsed| elapsed >= ...) to is_none_or(|elapsed| elapsed < ...) for clarity.

Risks / Follow-Ups

None identified.


Generated by RalphX


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@adriandemian
adriandemian marked this pull request as ready for review August 4, 2026 06:14
@adriandemian
adriandemian merged commit 120e550 into ralphx/ralphx/agent-ef006d8b Aug 4, 2026
1 check passed
@adriandemian
adriandemian deleted the ralphx/ralphx/agent-e643ef62 branch August 4, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant