Fix current branch CI - #983
Merged
adriandemian merged 2 commits intoAug 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update test assertions to match the current queue recovery behavior when
AgentRunpersistence fails during queued continuation processing. The message is now restored to the queue front instead of being consumed. Also simplify the publish-grace boolean for readability.User Impact
No user-facing impact; test alignment and code simplification only.
Technical Context
When
AgentRunpersistence fails during a queued continuation, the production code now restores the message to the queue front, decrementstotal_processed, and does not report a newlast_run_id. The testqueue_processing_stops_before_launch_when_run_persistence_failswas asserting the prior contract.This PR updates three assertions to reflect the current behavior:
total_processed == 0(failed run does not count as processed)last_run_id.is_none()(no run was persisted)Existing assertions (no
run_startedevent, queue slot release) remain valid under the new contract.Secondary change: simplify
scheduler.rsboolean condition from!elapsed_since(...).is_some_and(|elapsed| elapsed >= ...)tois_none_or(|elapsed| elapsed < ...)for clarity.Risks / Follow-Ups
None identified.
Generated by RalphX
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.