Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 10, 2025

This PR contains the following updates:

Package Change Age Confidence
pywin32 (changelog) >=310,<311 -> >=311,<312 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

mhammond/pywin32 (pywin32)

v311

  • Fix use-after-free in CertDeleteCertificateFromStore (#​2637)
  • Better support for COM identifiers with non-ascii characters (#​2632)
  • pywin32's own warnings will now refer to the caller, rather than to the internal source of warning itself (#​2594, [@​Avasam][Avasam])
  • Fixed a regression that broke special __dunder__ methods with CoClass. (#​1870, #​2493, [@​Avasam][Avasam], [@​geppi][geppi])
  • Fixed TypeError: cannot unpack non-iterable NoneType object when registering an axscript client ScriptItem (#​2513, [@​Avasam][Avasam])
  • Fixed a memory leak when SafeArrays are used as out parameters ([@​the-snork][the-snork])
  • Fixed dispatch handling for properties ([@​the-snork][the-snork])
  • Resolved a handful of deprecation warnings (#​2567, #​2576, [@​Avasam][Avasam])
  • The following classes now produce a valid eval string representation when calling repr: (#​2573, [@​Avasam][Avasam])
    • pywin.tools.browser.HLIPythonObject
    • win32com.server.exception.COMException
    • win32comext.axscript.client.error.AXScriptException
    • win32comext.axscript.client.pyscript.NamedScriptAttribute
  • Added initial DECIMAL/VT_DECIMAL support (#​1501, [@​gesslerpd][gesslerpd])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@claude
Copy link

claude bot commented Oct 10, 2025

Pull Request Review: Update pywin32 to v311

Summary

This PR updates the pywin32 dependency from version 310 to 311, a Windows-specific package used for file picker functionality and Windows shell integration.


Positive Aspects

  1. Security Fix: Version 311 includes an important fix for a use-after-free vulnerability in CertDeleteCertificateFromStore

  2. Bug Fixes: Multiple critical fixes including:

    • Memory leak fixes for SafeArrays used as out parameters
    • Fixed dispatch handling for properties
    • Fixed TypeError in axscript client registration
    • Fixed regression with special dunder methods in CoClass
  3. Improvements:

    • Better support for COM identifiers with non-ASCII characters
    • Warning messages now reference caller location (more useful debugging)
    • Added initial DECIMAL/VT_DECIMAL support
    • Resolved deprecation warnings
  4. Platform Coverage: The update includes wheels for Python 3.11, 3.12, 3.13, and 3.14 (new) across all Windows platforms

  5. Dependency Scope: Properly scoped with sys_platform == win32 marker, only affects Windows users


Code Analysis

Current Usage in Codebase:

  1. src/aignostics/utils/_gui.py:175 - Uses win32api.GetLogicalDriveStrings() for drive enumeration in the file picker
  2. src/aignostics/third_party/showinfm/system/windows.py:9 - Uses win32com.shell for Windows Explorer integration

Both usages are compatible with the update. The win32com.shell usage actually benefits from the improved dispatch handling and memory leak fixes.


Considerations

  1. Testing: The SDK appears to have limited Windows-specific testing. Manual verification recommended for GUI file picker and Windows Explorer integration.

  2. Formatting: Minor spacing inconsistency in pyproject.toml line 93 - space before semicolon was removed (acceptable style change)


Recommendations

  1. Approve the update - The security fix and bug fixes make this a worthwhile upgrade
  2. Manual testing if possible: Test the GUI file picker on Windows to verify drive enumeration
  3. Future consideration: Add Windows-specific integration tests for the file picker functionality

Verdict

LGTM - Recommend Merge

This is a straightforward dependency update with important security and stability improvements. The changes are backward compatible with the SDK current usage patterns. The update aligns with the repository security-first approach.

Compliance Check:

  • Follows modulith architecture principles
  • No breaking changes to service interfaces
  • Platform-specific dependency properly marked
  • No changes to test coverage requirements (85% minimum)
  • Auto-generated by Renovate bot (trusted source)

Review completed using repository CLAUDE.md guidance and codebase analysis

@helmut-hoffer-von-ankershoffen helmut-hoffer-von-ankershoffen merged commit 39428a2 into main Oct 10, 2025
10 of 16 checks passed
helmut-hoffer-von-ankershoffen pushed a commit that referenced this pull request Oct 12, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
helmut-hoffer-von-ankershoffen pushed a commit that referenced this pull request Oct 14, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
helmut-hoffer-von-ankershoffen pushed a commit that referenced this pull request Nov 2, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot deleted the renovate/pywin32-311.x branch November 2, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants