chore(deps): bump idc-index-data from 22.1.5 to 23.0.1#277
chore(deps): bump idc-index-data from 22.1.5 to 23.0.1#277helmut-hoffer-von-ankershoffen merged 6 commits intomainfrom
Conversation
Bumps [idc-index-data](https://github.com/ImagingDataCommons/idc-index-data) from 22.1.5 to 23.0.1. - [Release notes](https://github.com/ImagingDataCommons/idc-index-data/releases) - [Commits](ImagingDataCommons/idc-index-data@22.1.5...23.0.1) --- updated-dependencies: - dependency-name: idc-index-data dependency-version: 23.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
bot
dependabot
bot
requested a review
from helmut-hoffer-von-ankershoffen
as a code owner
dependabot
bot
added
dependencies
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude finished @dependabot[bot]'s task —— View job Dependency Update Review: idc-index-data 22.1.5 → 23.0.1 ✅SummaryVerdict: APPROVE with monitoring recommendation This is a routine data release update from the NCI Imaging Data Commons (IDC) with low breaking change risk. The major version bump (v22 → v23) reflects the underlying IDC data release version, not an API breaking change. Change DetailsDependency: Release Notes:
Risk Assessment✅ LOW RISK - Data Update, Not API ChangeWhat Changed:
Integration Points (Verified Stable): # src/aignostics/third_party/idc_index.py uses:
import idc_index_data
# Stable attributes used:
idc_index_data.__version__ # ✅ Standard attribute
idc_index_data.IDC_INDEX_PARQUET_FILEPATH # ✅ Stable constant
idc_index_data.PRIOR_VERSIONS_INDEX_PARQUET_FILEPATH # ✅ Stable constant
# Version parsing (adapts to major version):
self.idc_version = f"v{Version(idc_index_data.__version__).major}" # ✅ Now returns "v23"Why This is Safe:
📋 Test CoverageDataset module tests: 20 tests across 3 files ✅
All tests properly marked with required markers ( CI/CD Status
Note: Tests are still running but expected to pass based on:
Code Quality Checks✅ No Critical Issues FoundConventional Commits: ✅ PASS
Test Markers: ✅ PASS (all 20 tests properly marked) Type Checking: ✅ PASS (no changes to code, only dependency version) Architecture Compliance: ✅ PASS (no code changes) Recommendations✅ Approve and MergeRationale:
📊 Post-Merge MonitoringWhile risk is low, monitor these areas after deployment:
Test Commands: # After merge, verify dataset operations:
uv run aignostics dataset idc collections
uv run pytest -m "e2e and dataset" -v
# Check version detection:
python3 -c "from aignostics.third_party.idc_index import IDCClient; c=IDCClient.client(); print(f'IDC Version: {c.idc_version}')"
# Expected output: "IDC Version: v23"Medical Device Compliance✅ No Regulatory Impact
Final Verdict✅ APPROVE - Low-Risk Data Update This is a routine dependency update for the IDC v23 data release. The package is essentially a data bundle (Parquet index files) with stable API surface. No breaking changes detected. Action Items:
Questions/Concerns: None identified. This is a standard data release update following semantic versioning where major version tracks IDC data release version. |
Codecov Report✅ All modified and coverable lines are covered by tests. |
helmut-hoffer-von-ankershoffen
added
the
skip:codecov
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude finished @dependabot[bot]'s task —— View job Dependency Update Review: idc-index-data 22.1.5 → 23.0.1Review Checklist
✅ APPROVED - Low-Risk Data Release UpdateSummaryThis is a routine data release update from the NCI Imaging Data Commons (IDC) with minimal breaking change risk. The dependency bump from v22.1.5 to v23.0.1 primarily updates the underlying cancer imaging dataset index to IDC v23, with no API changes affecting the SDK. Change AnalysisDependency: What Changed:
Release Notes (from upstream):
Integration AnalysisSDK Usage (verified stable): The SDK uses # Line 48: Import dependency
import idc_index_data
# Line 60: Use __version__ for release URL (stable)
asset_endpoint_url = f"https://github.com/ImagingDataCommons/idc-index-data/releases/download/{idc_index_data.__version__}"
# Line 101: Use constant for index file path (stable)
file_path = idc_index_data.IDC_INDEX_PARQUET_FILEPATH
# Line 115: Use constant for prior versions index (stable)
file_path = idc_index_data.PRIOR_VERSIONS_INDEX_PARQUET_FILEPATH
# Line 127: Version-adaptive parsing (stable)
self.idc_version = f"v{Version(idc_index_data.__version__).major}" # Now returns "v23" (was "v22")Why This is Safe:
Test Coverage VerificationDataset Module Tests: ✅ 20 tests across 3 files (all properly marked) Test Files:
Test Marker Compliance: ✅ PASSED All dataset tests have required markers (
Sample markers verified: @pytest.mark.integration # Line 21
@pytest.mark.flaky(retries=1, delay=5)
@pytest.mark.timeout(timeout=60 * 2)
def test_cli_idc_indices():
...
@pytest.mark.e2e # Line 34
@pytest.mark.flaky(retries=1, delay=5)
@pytest.mark.timeout(timeout=60 * 2)
def test_cli_idc_columns_default_index():
...CI/CD Status
Codecov: ✅ All modified lines covered (no code changes, only dependency version) Architecture ComplianceModulith Principles: ✅ COMPLIANT
Service Pattern: ✅ COMPLIANT
Medical Domain Context: ✅ COMPLIANT
Breaking Change AssessmentRisk Level: 🟢 MINIMAL Checked for:
Version Semantic Analysis:
Medical Device & Security ComplianceRegulatory Impact: ✅ NONE
Security Audit: ✅ CLEAN
Conventional CommitsCommit Message: ✅ COMPLIANT
Post-Merge Monitoring RecommendationsWhile this is a low-risk change, monitor these areas after deployment: 1. Dataset Downloads (Priority: Medium) # Verify IDC v23 collections are accessible
aignostics dataset idc collections
# Test download with new index
aignostics dataset idc download --collection-id TCGA-LUAD --dry-run2. E2E Test Execution # Run dataset E2E tests against staging
uv run pytest -m "e2e and dataset" -v3. Version Detection # Verify SDK correctly detects IDC v23
from aignostics.third_party.idc_index import IDCClient
client = IDCClient.client()
assert client.idc_version == "v23" # Updated from "v22"4. Error Monitoring
Findings Summary
Final Recommendation✅ APPROVE AND MERGE Rationale:
Next Steps:
Questions/Concerns: None identified. This is a standard data release update following semantic versioning where the major version tracks the IDC data release version (not API changes). |
|
Claude finished @dependabot[bot]'s task —— View job Re-Review: idc-index-data 22.1.5 → 23.0.1Todo List
✅ RE-APPROVAL - No Changes Since Last ReviewStatus: This PR was synchronized (rebased with main) but no changes to the dependency update itself. What Changed Since Dec 1 Review?Dependency Change: Still the same - Branch Updates: The PR branch was merged with main 4 times to stay current:
No functional changes - These are automatic Dependabot merge commits to keep the PR up-to-date with main. Previous Review Findings (Dec 1, 2025)✅ APPROVED - Low-risk data release update Key Points from Prior Review:
Current CI/CD Status
Previous CI Runs: All passed (Lint ✅, CodeQL ✅, SonarQube ✅, Codecov ✅) Change AnalysisExact Diff: - "idc-index-data==22.1.5",
+ "idc-index-data==23.0.1",No other changes - Single line dependency version update only. Integration Points (verified stable in Dec 1 review):
Final Recommendation✅ RE-APPROVE AND MERGE Rationale:
Next Steps:
No New Issues Identified - All findings from Dec 1 review remain valid and addressed. References: |
|
1 participant
Bumps idc-index-data from 22.1.5 to 23.0.1.
Release notes
Sourced from idc-index-data's releases.
Commits
810fcedenh: update to IDC v232264f3cenh: add missing descriptionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)