Fix the LoopCommunicator.remove_broadcast_subscriber#156
Merged
Conversation
Collaborator
Author
|
P.S.: the tests for this should fail because there is also a comparable bug in |
sphuber
force-pushed
the
fix/155/loop-communicator
branch
from
721d8b2 to
f341c1e
Compare
muhrin
approved these changes
Jun 5, 2020
The `remove_broadcast_subscriber` method was piping through to the `remove_task_subscriber` method, which is probably a copy and paste error that went unnoticed because the entire class was unused and untested. Also change the logging level when required attribute of a `Port` is overridden by a default from `INFO` to `DEBUG` as this is a very common operation and was way too noisy.
sphuber
force-pushed
the
fix/155/loop-communicator
branch
from
f341c1e to
22dcfff
Compare
unkcpz
pushed a commit
to unkcpz/plumpy
that referenced
this pull request
Dec 14, 2024
The `remove_broadcast_subscriber` method was piping through to the `remove_task_subscriber` method, which is probably a copy and paste error that went unnoticed because the entire class was unused and untested. Also change the logging level when required attribute of a `Port` is overridden by a default from `INFO` to `DEBUG` as this is a very common operation and was way too noisy.
agoscinski
pushed a commit
to agoscinski/plumpy
that referenced
this pull request
Apr 13, 2026
The `remove_broadcast_subscriber` method was piping through to the `remove_task_subscriber` method, which is probably a copy and paste error that went unnoticed because the entire class was unused and untested. Also change the logging level when required attribute of a `Port` is overridden by a default from `INFO` to `DEBUG` as this is a very common operation and was way too noisy.
agoscinski
pushed a commit
that referenced
this pull request
Apr 13, 2026
The `remove_broadcast_subscriber` method was piping through to the `remove_task_subscriber` method, which is probably a copy and paste error that went unnoticed because the entire class was unused and untested. Also change the logging level when required attribute of a `Port` is overridden by a default from `INFO` to `DEBUG` as this is a very common operation and was way too noisy.
agoscinski
pushed a commit
that referenced
this pull request
Apr 13, 2026
The `remove_broadcast_subscriber` method was piping through to the `remove_task_subscriber` method, which is probably a copy and paste error that went unnoticed because the entire class was unused and untested. Also change the logging level when required attribute of a `Port` is overridden by a default from `INFO` to `DEBUG` as this is a very common operation and was way too noisy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155
The
remove_broadcast_subscribermethod was piping through to theremove_task_subscribermethod, which is probably a copy and pasteerror that went unnoticed because the entire class was unused and
untested.
Also change the logging level when required attribute of a
Portisoverridden by a default from
INFOtoDEBUGas this is a very commonoperation and was way too noisy.