Skip to content

Remove dependency of typing-extensions#300

Merged
unkcpz merged 1 commit intoaiidateam:masterfrom
unkcpz:remove-typing-extensions-dep
Dec 16, 2024
Merged

Remove dependency of typing-extensions#300
unkcpz merged 1 commit intoaiidateam:masterfrom
unkcpz:remove-typing-extensions-dep

Conversation

@unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 14, 2024

Since kiwipy pinning the upbound version of aio-pika to 9.4.0 to not include the bug of typing-extentions import error of mosquito/aio-pika#649.

Since kiwipy pinning the upbound version of aio-pika to 9.4.0 to not
include the bug of typing-extentions import error of
mosquito/aio-pika#649.
@unkcpz unkcpz requested a review from khsrali December 16, 2024 08:14
@unkcpz
Copy link
Member Author

unkcpz commented Dec 16, 2024

@khsrali I think this can safely go (and better) with the 0.23.0 release.

@khsrali
Copy link
Contributor

khsrali commented Dec 16, 2024

Thanks @unkcpz
I'm confused, because aiida-core pins 'aio-pika~=6.6'
just to understand, how come there is no package conflict ?
LGTM!

@unkcpz unkcpz merged commit e06d522 into aiidateam:master Dec 16, 2024
@unkcpz unkcpz deleted the remove-typing-extensions-dep branch December 16, 2024 10:14
khsrali pushed a commit that referenced this pull request Dec 19, 2024
Since kiwipy pinning the upbound version of aio-pika to 9.4.0 to not
include the bug of typing-extentions import error of
mosquito/aio-pika#649.
khsrali pushed a commit that referenced this pull request Dec 19, 2024
Since kiwipy pinning the upbound version of aio-pika to 9.4.0 to not
include the bug of typing-extentions import error of
mosquito/aio-pika#649.

(cherry picked from commit e06d522)
khsrali pushed a commit that referenced this pull request Dec 19, 2024
Since kiwipy pinning the upbound version of aio-pika to 9.4.0 to not
include the bug of typing-extentions import error of
mosquito/aio-pika#649.

(cherry picked from commit e06d522)
khsrali pushed a commit that referenced this pull request Dec 19, 2024
Since kiwipy pinning the upbound version of aio-pika to 9.4.0 to not
include the bug of typing-extentions import error of
mosquito/aio-pika#649.

(cherry picked from commit e06d522)
khsrali pushed a commit that referenced this pull request Dec 19, 2024
Since kiwipy pinning the upbound version of aio-pika to 9.4.0 to not
include the bug of typing-extentions import error of
mosquito/aio-pika#649.

(cherry picked from commit e06d522)
khsrali pushed a commit that referenced this pull request Dec 19, 2024
Since kiwipy pinning the upbound version of aio-pika to 9.4.0 to not
include the bug of typing-extentions import error of
mosquito/aio-pika#649.

(cherry picked from commit e06d522)
khsrali pushed a commit that referenced this pull request Dec 19, 2024
Since kiwipy pinning the upbound version of aio-pika to 9.4.0 to not
include the bug of typing-extentions import error of
mosquito/aio-pika#649.

(cherry picked from commit e06d522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants