Open
Conversation
Addressing issue facebook#4717. These changes make it clear how to extend the prototype and constructor of a class. Methods added in the class declaration do not need to be annotated. At this time, methods and properties defined on the constructor (static) and on the prototype need to be annotated in the class definition. This is probably a best practice since, if the class is modified in a location not local to the definition we will want the type checker to notify us.
|
Thanks for putting this up. But it seems that this PR merges against your local master, instead of upstream master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue facebook#4717.
These changes make it clear how to extend the prototype and constructor of a class. Methods added in the class declaration do not need to be annotated. At this time, methods and properties defined on the constructor (static) and on the prototype need to be annotated in the class definition. This is probably a best practice since, if the class is modified in a location not local to the definition we will want the type checker to notify us.