Skip to content

Conversation

@Dreamsorcerer
Copy link
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot labels Jan 2, 2026
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 99.35484% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.75%. Comparing base (18bc50b) to head (3f63b58).
⚠️ Report is 12 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tests/test_client_functional.py 98.52% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #11898    +/-   ##
========================================
  Coverage   98.75%   98.75%            
========================================
  Files         127      127            
  Lines       44245    44451   +206     
  Branches     2344     2349     +5     
========================================
+ Hits        43693    43897   +204     
- Misses        392      393     +1     
- Partials      160      161     +1     
Flag Coverage Δ
CI-GHA 98.61% <99.35%> (-0.01%) ⬇️
OS-Linux 98.35% <99.35%> (-0.01%) ⬇️
OS-Windows 96.69% <98.70%> (-0.01%) ⬇️
OS-macOS 97.57% <98.70%> (+<0.01%) ⬆️
Py-3.10.11 97.12% <98.06%> (+<0.01%) ⬆️
Py-3.10.19 97.61% <98.06%> (+<0.01%) ⬆️
Py-3.11.14 97.81% <98.06%> (+<0.01%) ⬆️
Py-3.11.9 97.33% <98.06%> (+<0.01%) ⬆️
Py-3.12.10 97.42% <98.06%> (+<0.01%) ⬆️
Py-3.12.12 97.91% <98.06%> (-0.01%) ⬇️
Py-3.13.11 98.17% <98.06%> (+<0.01%) ⬆️
Py-3.14.2 98.14% <87.09%> (-0.05%) ⬇️
Py-3.14.2t 97.21% <87.09%> (-0.05%) ⬇️
Py-pypy3.11.13-7.3.20 97.37% <79.35%> (-0.06%) ⬇️
VM-macos 97.57% <98.70%> (+<0.01%) ⬆️
VM-ubuntu 98.35% <99.35%> (-0.01%) ⬇️
VM-windows 96.69% <98.70%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 2, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 3, 2026

CodSpeed Performance Report

Merging #11898 will not alter performance

Comparing s11 (3f63b58) with master (d5bf65f)

Summary

✅ 59 untouched

@bdraco
Copy link
Member

bdraco commented Jan 3, 2026

is_finished doesn't do what I thought it does

@bdraco
Copy link
Member

bdraco commented Jan 3, 2026

but brotli and brotlicffi have different behavior. brotlicffi enforces limit ,brotli lazy enforces it

@bdraco
Copy link
Member

bdraco commented Jan 3, 2026

Still need some more cleanup, but skipped lunch so I need to go get some food

@Dreamsorcerer Dreamsorcerer merged commit 92477c5 into master Jan 3, 2026
41 checks passed
@Dreamsorcerer Dreamsorcerer deleted the s11 branch January 3, 2026 14:41
@patchback
Copy link
Contributor

patchback bot commented Jan 3, 2026

Backport to 3.13: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 92477c5 on top of patchback/backports/3.13/92477c5a74c43dfe0474bd24f8de11875daa2298/pr-11898

Backporting merged PR #11898 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.13/92477c5a74c43dfe0474bd24f8de11875daa2298/pr-11898 upstream/3.13
  4. Now, cherry-pick PR Use decompressor max_length parameter #11898 contents into that branch:
    $ git cherry-pick -x 92477c5a74c43dfe0474bd24f8de11875daa2298
    If it'll yell at you with something like fatal: Commit 92477c5a74c43dfe0474bd24f8de11875daa2298 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 92477c5a74c43dfe0474bd24f8de11875daa2298
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Use decompressor max_length parameter #11898 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.13/92477c5a74c43dfe0474bd24f8de11875daa2298/pr-11898
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Contributor

patchback bot commented Jan 3, 2026

Backport to 3.14: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 92477c5 on top of patchback/backports/3.14/92477c5a74c43dfe0474bd24f8de11875daa2298/pr-11898

Backporting merged PR #11898 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.14/92477c5a74c43dfe0474bd24f8de11875daa2298/pr-11898 upstream/3.14
  4. Now, cherry-pick PR Use decompressor max_length parameter #11898 contents into that branch:
    $ git cherry-pick -x 92477c5a74c43dfe0474bd24f8de11875daa2298
    If it'll yell at you with something like fatal: Commit 92477c5a74c43dfe0474bd24f8de11875daa2298 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 92477c5a74c43dfe0474bd24f8de11875daa2298
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Use decompressor max_length parameter #11898 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.14/92477c5a74c43dfe0474bd24f8de11875daa2298/pr-11898
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Dreamsorcerer added a commit that referenced this pull request Jan 3, 2026
Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit 92477c5)
Dreamsorcerer added a commit that referenced this pull request Jan 3, 2026
Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit 92477c5)
Dreamsorcerer added a commit that referenced this pull request Jan 3, 2026
(cherry picked from commit 92477c5)

---------

Co-authored-by: J. Nick Koston <nick@koston.org>
Dreamsorcerer added a commit that referenced this pull request Jan 3, 2026
(cherry picked from commit 92477c5)

---------

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants