Conversation
|
Does this actually work? I know it got broken and stopped working in other projects.. I haven't figured out why. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12349 +/- ##
==========================================
- Coverage 99.11% 99.11% -0.01%
==========================================
Files 130 130
Lines 45626 45629 +3
Branches 2405 2406 +1
==========================================
Hits 45224 45224
- Misses 272 274 +2
- Partials 130 131 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merging this PR will degrade performance by 20.13%
Performance Changes
Comparing Footnotes
|
No idea, that's what codecov is for. A quick test locally suggested that coverage was getting reported. |
|
Oh, and Cython needs to be installed into the same env as coveragepy for it to be able to load that plugin. |
|
There seem to be some tests which completely cripple the performance. I think the only reasonable option would be to use a separate job that disables blockbuster and runs a subset of the test suite with tracing. |
|
Doesn't seem to be making it to codecov at all anyway.. |
|
There is definitely coverage when running these steps locally. Can't find any reason why this is not producing coverage in CI.... |
|
Cython tracing is broken on Python 3.13+ due to https://peps.python.org/pep-0669/ |
No description provided.