Skip to content

Add Cython coverage#12349

Draft
Dreamsorcerer wants to merge 26 commits intomasterfrom
cython-cov
Draft

Add Cython coverage#12349
Dreamsorcerer wants to merge 26 commits intomasterfrom
cython-cov

Conversation

@Dreamsorcerer
Copy link
Copy Markdown
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added the backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot label Apr 10, 2026
@webknjaz
Copy link
Copy Markdown
Member

Does this actually work? I know it got broken and stopped working in other projects.. I haven't figured out why.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.11%. Comparing base (f55503d) to head (3b10bbb).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tests/conftest.py 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12349      +/-   ##
==========================================
- Coverage   99.11%   99.11%   -0.01%     
==========================================
  Files         130      130              
  Lines       45626    45629       +3     
  Branches     2405     2406       +1     
==========================================
  Hits        45224    45224              
- Misses        272      274       +2     
- Partials      130      131       +1     
Flag Coverage Δ
CI-GHA 98.96% <0.00%> (-0.01%) ⬇️
OS-Linux 98.71% <0.00%> (-0.01%) ⬇️
OS-Windows 96.96% <0.00%> (-0.01%) ⬇️
OS-macOS 97.86% <0.00%> (-0.01%) ⬇️
Py-3.10.11 97.42% <0.00%> (-0.01%) ⬇️
Py-3.10.20 97.89% <0.00%> (-0.01%) ⬇️
Py-3.11.15 98.09% <0.00%> (-0.02%) ⬇️
Py-3.11.9 97.63% <0.00%> (-0.01%) ⬇️
Py-3.12.10 97.72% <0.00%> (-0.01%) ⬇️
Py-3.12.13 98.19% <0.00%> (-0.02%) ⬇️
Py-3.13.12 98.43% <0.00%> (-0.02%) ⬇️
Py-3.14.3 98.49% <0.00%> (-0.01%) ⬇️
Py-3.14.4t 97.50% <0.00%> (-0.01%) ⬇️
Py-pypy3.11.15-7.3.21 97.37% <0.00%> (-0.01%) ⬇️
VM-macos 97.86% <0.00%> (-0.01%) ⬇️
VM-ubuntu 98.71% <0.00%> (-0.01%) ⬇️
VM-windows 96.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 10, 2026

Merging this PR will degrade performance by 20.13%

❌ 1 regressed benchmark
✅ 60 untouched benchmarks
⏩ 4 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
test_ten_streamed_responses_iter_chunks[pyloop] 131.1 ms 164.1 ms -20.13%

Comparing cython-cov (3b10bbb) with master (f55503d)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dreamsorcerer
Copy link
Copy Markdown
Member Author

Does this actually work? I know it got broken and stopped working in other projects.. I haven't figured out why.

No idea, that's what codecov is for. A quick test locally suggested that coverage was getting reported.

@webknjaz
Copy link
Copy Markdown
Member

Oh, and Cython needs to be installed into the same env as coveragepy for it to be able to load that plugin.

@Dreamsorcerer Dreamsorcerer marked this pull request as draft April 10, 2026 23:24
@Dreamsorcerer
Copy link
Copy Markdown
Member Author

There seem to be some tests which completely cripple the performance. I think the only reasonable option would be to use a separate job that disables blockbuster and runs a subset of the test suite with tracing.

@Dreamsorcerer
Copy link
Copy Markdown
Member Author

Doesn't seem to be making it to codecov at all anyway..

@Dreamsorcerer
Copy link
Copy Markdown
Member Author

There is definitely coverage when running these steps locally. Can't find any reason why this is not producing coverage in CI....

@Dreamsorcerer
Copy link
Copy Markdown
Member Author

Cython tracing is broken on Python 3.13+ due to https://peps.python.org/pep-0669/
Need to rely on Python 3.12 until that is hopefully resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants