chore: field names must not be verbs.#1078
Merged
shwoodard merged 3 commits intoaip-dev:masterfrom May 2, 2023
Merged
Conversation
Add guidance that field names must not be expressed in the context of imperatives or actions, as verbs. Fixes: aip-dev#1077
toumorokoshi
suggested changes
Apr 26, 2023
Contributor
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
Thanks! one question on the declarative section.
noahdietz
reviewed
Apr 26, 2023
shwoodard
added a commit
to shwoodard/google.aip.dev
that referenced
this pull request
Apr 27, 2023
Overall, make shorter and more direct. Specifically, * Incorporate that nounds for field names are important as it reflects mutation and get semantics into a single paragraph. * Change one example to boolean. * Remove Note about best for Delcarative Friendly/IaC.
Overall, make shorter and more direct. Specifically, * Incorporate that nounds for field names are important as it reflects mutation and get semantics into a single paragraph. * Change one example to boolean. * Remove Note about best for Delcarative Friendly/IaC.
shwoodard
force-pushed
the
aip-140-issue-1077-adjectives-and-verbs
branch
from
7f4de0d to
86d5561
Compare
noahdietz
approved these changes
Apr 27, 2023
bgrant0607
reviewed
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add guidance that field names must not be expressed in the context of imperatives or actions, as verbs.
Fixes: #1077