fix(AIP-157): prefix top-level enum values#1092
Merged
noahdietz merged 2 commits intoaip-dev:masterfrom May 9, 2023
Merged
Conversation
toumorokoshi
approved these changes
May 9, 2023
Contributor
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
LGTM! add a changelog?
Collaborator
Author
Oops, thanks for catching that. Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the example
Viewenum to use prefixed values since it is also recommended that the enum definition is top level. According to AIP-126, top-level enum values should be prefixed to avoid collisions in generated code.