chore(AIP-130): fix formatting#1199
Merged
noahdietz merged 1 commit intoaip-dev:masterfrom Aug 16, 2023
Merged
Conversation
AIP-130 was illegible on the aip site due to the size of the table. Condensing by two columns makes the content legible (5 columns seems to be the max for the current aip-site).
bgrant0607
approved these changes
Aug 16, 2023
Contributor
bgrant0607
left a comment
bgrant0607
left a comment
There was a problem hiding this comment.
LGTM. The rendered markdown looks fine. I don't know how to preview the site.
noahdietz
approved these changes
Aug 16, 2023
Contributor
Author
You'd have to clone the repo and run Next time I'll just try to add a screenshot. UI previous are always awkward in PRs. |
Collaborator
|
I wonder if we could get GH actions to build it as a preview and link to it here, like g3docs...perhaps only when a specific label is added to avoid blowing things up... It's live now and looks great :) https://google.aip.dev/130 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIP-130 was illegible on the aip site due to the size of the table.
Condensing by two columns makes the content legible (5 columns seems to be the max for the current aip-site).