fix(AIP-132): Require documentation for ordering not matching field type#1484
Merged
noahdietz merged 5 commits intoaip-dev:masterfrom Feb 26, 2025
Merged
Conversation
noahdietz
reviewed
Feb 24, 2025
Collaborator
noahdietz
left a comment
noahdietz
left a comment
There was a problem hiding this comment.
Great start @AidanWelch thank you!
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
…type with clarification on ordering of well-known types
AidanWelch
force-pushed
the
aip-132-ordering-clarification
branch
from
5381d3c to
936cf67
Compare
noahdietz
reviewed
Feb 25, 2025
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
noahdietz
approved these changes
Feb 26, 2025
Collaborator
noahdietz
left a comment
noahdietz
left a comment
There was a problem hiding this comment.
Thank you @AidanWelch ! Please catch up your branch and I can submit this.
Contributor
Author
|
@noahdietz Synced. Thanks for your help on this! |
noahdietz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using similar language to https://google.aip.dev/160#literals require that ordering differing from what's expected of a field (given its type) be documented.
Fixes #1483