feat(AIP-121): require Get for mutable resources#993
Merged
shwoodard merged 5 commits intoaip-dev:masterfrom Dec 21, 2022
Merged
feat(AIP-121): require Get for mutable resources#993shwoodard merged 5 commits intoaip-dev:masterfrom
shwoodard merged 5 commits intoaip-dev:masterfrom
Conversation
Resources that do not support Get but support mutable operations make customers unable to validate the state of their resources for long-term synchronization use cases like drift detection or state management. See pulumi/pulumi-google-native#47 for an example of the issue.
shwoodard
requested changes
Dec 20, 2022
use "validate the state of the resource", since that's actually what's being done here. Not so much "operation completion", which should be detected via LRO or request completion.
Contributor
|
Yeah! Thanks! I'm not aware of any justified exceptions to this, but if any do arise, they should be enumerated explicitly rather than weakening the language. |
loudej
reviewed
Dec 20, 2022
- Making Get and List required as requiring them for a mutable operation effectively makes a resource only valid if it supports these operations.
Contributor
|
LGTM |
bgrant0607
approved these changes
Dec 20, 2022
noahdietz
reviewed
Dec 20, 2022
- Lists cannot exist in the case of singleton resources, so calling out that edge case specifically as not requiring List.
noahdietz
reviewed
Dec 20, 2022
Collaborator
noahdietz
left a comment
noahdietz
left a comment
There was a problem hiding this comment.
LGTM but please allow @shwoodard to Approve
shwoodard
approved these changes
Dec 21, 2022
toumorokoshi
added a commit
to toumorokoshi/google.aip.dev
that referenced
this pull request
Dec 21, 2022
- fixing formatting (e.g. bolding of must) - removing the CRUDL + custom methods restriction, as the terminology was not clear and very little is actually limited by adding that line. - updating guidance for Get and List to match aip-dev#993. - fixing wording of stateless to clarify referring to stateless protocols.
toumorokoshi
added a commit
to toumorokoshi/google.aip.dev
that referenced
this pull request
Dec 21, 2022
- fixing formatting (e.g. bolding of must) - removing the CRUDL + custom methods restriction, as the terminology was not clear and very little is actually limited by adding that line. - updating guidance for Get and List to match aip-dev#993. - fixing wording of stateless to clarify referring to stateless protocols.
toumorokoshi
added a commit
to toumorokoshi/google.aip.dev
that referenced
this pull request
Dec 21, 2022
- fixing formatting (e.g. bolding of must) - removing the CRUDL + custom methods restriction, as the terminology was not clear and very little is actually limited by adding that line. - updating guidance for Get and List to match aip-dev#993. - fixing wording of stateless to clarify referring to stateless protocols.
toumorokoshi
added a commit
to toumorokoshi/google.aip.dev
that referenced
this pull request
Mar 17, 2023
With aip-dev#993, Get and List are required for resources as stated in AIP-121. Fixe the guidance to match in the more specific AIPs.
toumorokoshi
added a commit
that referenced
this pull request
Mar 20, 2023
nitinapi
pushed a commit
to nitinapi/google.aip.dev
that referenced
this pull request
Apr 5, 2023
With aip-dev#993, Get and List are required for resources as stated in AIP-121. Fixe the guidance to match in the more specific AIPs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resources that do not support Get but support mutable operations make customers unable to validate the
state of their resources for long-term synchronization use cases like drift detection or state management.
See pulumi/pulumi-google-native#47 for an example of the issue.