fix(packaging): use ${arch} instead of hardcoded amd64 in deb template#369
Merged
Conversation
Codex Correctness ReviewVerdict: mergeable No actionable findings. |
electron-builder's getArtifactArchName() automatically maps x64 to 'amd64' when ext === 'deb', so the arch template variable expands correctly. Hardcoding 'amd64' was unnecessary and would break future multi-arch builds (e.g. arm64).
ewen-poch
force-pushed
the
fix/deb-arch-dynamic
branch
from
July 23, 2026 08:48
9da640a to
8d76178
Compare
Codex Correctness ReviewVerdict: mergeable No actionable findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The previous fix (#368) hardcoded
amd64in the debartifactNameto work around${arch}expanding tox64. But this was based on an incorrect assumption — electron-builder already handles the mapping correctly.Proposed change
Revert to
${arch}in the deb template:aipoch-${name}_${version}_${arch}.${ext}electron-builder's
getArtifactArchName()(builder-util/out/arch.js:58-67) automatically mapsx64→amd64whenext === "deb". So${arch}expands toamd64for the current x64 build, and would correctly producearm64for a future arm64 build — which the hardcoded version would not.Scope and non-goals
One-line change. Test fixtures stay as-is (
amd64matches what${arch}expands to).Acceptance criteria and validation
electron-builder-config.test.ts+generate-version-manifest.test.ts)builder-util/out/arch.js:65confirmsext === "deb"→archName = "amd64"