fix(permissions): keep Undo stack above window bottom - #552
Merged
Conversation
Use a content-sized overflow container instead of the full-height Radix viewport. The viewport required a definite parent height and could lay out bottom-anchored Undo receipts below the visible window on Windows.
Codex ReviewVerdict: mergeable No actionable findings. Summary: Static inspection found no concrete merge-blocking defect in the pull request changes. |
ewen-poch
marked this pull request as ready for review
July 31, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, closing the permission surface could leave the Undo snackbar below the visible window. The fixed stack used the shared Radix ScrollArea with a full-height viewport, but its root only had a maximum height. Without a definite parent height, the bottom-anchored content could be laid out past the viewport.
Proposed change
Scope and non-goals
This change only affects the permission Undo stack layout. It does not change grant revocation, restoration, expiry, queueing, or other shared ScrollArea consumers.
Acceptance criteria and validation
The checks below ran against the final material implementation:
npm test -- src/renderer/src/components/PermissionUndoSnackbar.test.tsx-> passed, 6/6 tests.npx --no-install eslint src/renderer/src/components/PermissionUndoSnackbar.tsx src/renderer/src/components/PermissionUndoSnackbar.test.tsx-> passed.git diff --check-> passed.npm run lint-> passed with 0 errors; unrelated baseline warnings remain.npm run typecheck-> blocked because this worktree does not have the lockfile dependenciesfflateandtiffinstalled.npm test-> not completed in the restricted sandbox; localhost-listening tests failed withEPERMand the runner was terminated after five minutes.Uncovered risk: the structural regression is deterministic, but the final layout has not been visually exercised on a Windows Electron runtime.
Review focus
Please verify that the content-sized overflow container keeps single and queued Undo receipts above the bottom edge without changing restore, dismiss, expiry, or modal interaction behavior.