fix(notebook): close environment leases on disposal - #585
Merged
Conversation
Codex ReviewVerdict: mergeable No actionable findings. Summary: No concrete merge-blocking defects found in the pull request changes. Branch and title checks are valid; review was static-only as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Notebook runtime terminal disposal did not close its environment lease coordinator. A queued lease acquisition could therefore complete after the runtime crossed its disposal boundary, while releases from already-held leases could still mutate shutdown state.
Proposed change
Scope and non-goals
Acceptance criteria and validation
dispose(), held release returnsfalse, and runtime disposal completes: covered bysrc/main/notebook/runtime-service.test.ts.npm run typecheck: passed.npm run lint: passed with 0 errors and the existing 23 warnings.npm test: 630 files passed, 15 skipped; 9,356 tests passed, 184 skipped.Review focus
Related: #577