Skip to content

fix(compute): unify SSH Compute Skill materialization - #601

Merged
ewen-poch merged 1 commit into
aipoch:mainfrom
wen2zhou:fix/duplicate-ssh-compute-skill
Aug 2, 2026
Merged

fix(compute): unify SSH Compute Skill materialization#601
ewen-poch merged 1 commit into
aipoch:mainfrom
wen2zhou:fix/duplicate-ssh-compute-skill

Conversation

@wen2zhou

@wen2zhou wen2zhou commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Problem

SSH Compute was materialized both as the bundled os-remote-compute-ssh Skill and as a bare remote-compute-ssh runtime document. The two documents could diverge, and generic Skill refreshes could overwrite the live host projection.

Proposed change

Use os-remote-compute-ssh/SKILL.md as the sole canonical document. Preserve its host projection during generic materialization, synchronize it before agent discovery and after Compute host mutations, and remove only the known bare legacy directory.

Scope and non-goals

This change only affects SSH Compute Skill provisioning. It does not alter Specialist switching, connector filtering, host persistence, SSH APIs, or Settings UI behavior.

Acceptance criteria and validation

  • Bootstrap, generic refresh ordering, host create/delete, legacy cleanup, and filesystem discovery -> npm test -- src/main/compute/skill-provisioning.test.ts src/main/compute/skill-doc.test.ts src/main/skills/materializer.test.ts src/main/compute/ipc.test.ts src/main/settings/agent-runtime-manager.test.ts -> passed (80 tests).
  • TypeScript validation -> npm run typecheck -> passed.
  • Lint validation -> npm run lint -> passed.
  • Full suite -> npm test -> attempted after the final material edit; blocked by the worktree/Vite filesystem restriction denying access to the parent-repository pdfjs-dist worker import. This fails unrelated renderer preview tests before they initialize.

Review focus

Please verify the canonical-path ownership boundary, preservation of dynamic host data across a bundled Skill refresh, and the narrow legacy-directory cleanup.

@github-actions github-actions Bot added the bug Something isn't working label Aug 2, 2026
@wen2zhou
wen2zhou marked this pull request as draft August 2, 2026 01:56
@ewen-poch
ewen-poch marked this pull request as ready for review August 2, 2026 06:44
@ewen-poch
ewen-poch merged commit 259c84c into aipoch:main Aug 2, 2026
53 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants