ci(pr-gate): consolidate runner bundles - #602
Conversation
|
CI Integrity is expected to report |
Codex ReviewVerdict: needs changes [P1] Change to protected PR Gate workflow is rejected by CI Integrity.github/workflows/pr-gate.yml:201 Impact: The trusted CI Integrity workflow reports a protected-gate-control-plane violation for any content change to this file, so the required check fails and the pull request cannot merge. Recommendation: Obtain the explicit maintainer ruleset bypass required for protected gate changes, or use the repository’s approved control-plane migration process. Summary: Static inspection found a repository-enforced CI integrity blocker: this pull request modifies the protected PR Gate control-plane workflow without an in-repository maintainer bypass. |
|
Acknowledged. This PR intentionally changes the protected PR Gate control plane, and the CI Integrity failure confirms that the tripwire is working. No in-repository bypass will be added. A maintainer should use the configured ruleset bypass only after the consolidated PR Gate and the remaining review checks complete successfully. |
Problem
PR validation currently repeats checkout, Node setup,
npm ci, Electron builds, and equivalent E2E journeys acrossPR Gate,PR Check, and the standalone Windows portability workflow. The duplicate workflows also expose overlapping required-check surfaces, while the lane-level implementation inPR Gatecan allocate more than twenty runners for a full change.Proposed change
PR Gateas the single stable required check and preserve dependency-aware lane selection.PR Check, standalone commit-message check, and standalone Windows path-portability workflows.merge_groupsupport, immutable Action references, trusted-base classification, and fail-closed final aggregation.Scope and non-goals
This changes CI execution topology only. It does not change product architecture, source code, data models, data relationships, or user interaction. AI PR Review remains advisory and outside the required gate. Release, nightly, and platform soak workflows remain independent.
Acceptance criteria and validation
All listed checks ran after the last material workflow edit.
actionlint .github/workflows/pr-gate.yml .github/workflows/ci-integrity.ymlnpm exec vitest run scripts/cinpm run typechecknpm run lintnpm testgit diff --checknode scripts/ci/check-ci-integrity.mjs --base b9f9d99b87d40232695547c94bca09bd91a99fdf --head 96134f2d1b2d6e78dd46557a49f1dafb577a9434protected-gate-control-planeIndependent Standards and Spec reviews found no issues.
Review focus
continue-on-errorstep collection.PR Gateevaluates the base-branch policy and supports merge queues.CI Integrityis expected to fail on this PR because.github/workflows/pr-gate.ymlis an established protected control-plane file. Once the checks and review evidence are satisfactory, merging requires the configured maintainer ruleset bypass.