feat(composer): show platform search shortcut - #653
Merged
Conversation
ewen-poch
marked this pull request as ready for review
August 3, 2026 05:49
Codex ReviewVerdict: mergeable No actionable findings. Summary: No concrete merge-blocking defect found. Branch and pull request title checks are valid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The composer placeholder does not advertise the existing global-search shortcut, and the displayed key combination needs to match the user's platform.
Proposed change
⌘Kon macOS andCtrl+Kon Windows and Linux.Scope and non-goals
This only changes the placeholder copy and its platform-specific presentation. It does not change the existing global-search command, keyboard handling, architecture, or data model.
Acceptance criteria and validation
All checks listed below ran against the final rebased state:
npm test -- --run src/renderer/src/pages/workspace/ConversationPanel.interaction.test.tsx-> 48 tests passed.npm run typecheck-> passed.npm run lint-> passed with 0 errors and 18 pre-existing warnings.npm test-> 10,072 tests passed and 184 skipped across 690 passed and 15 skipped files.Uncovered risk: the placeholder was not visually snapshot-tested at every window width; existing responsive text truncation behavior remains unchanged.
Review focus
Please verify the platform mapping and user-facing wording.