Skip to content

feat(composer): show platform search shortcut - #653

Merged
ewen-poch merged 1 commit into
mainfrom
feat/platform-search-placeholder
Aug 3, 2026
Merged

feat(composer): show platform search shortcut#653
ewen-poch merged 1 commit into
mainfrom
feat/platform-search-placeholder

Conversation

@ewen-poch

Copy link
Copy Markdown
Member

Problem

The composer placeholder does not advertise the existing global-search shortcut, and the displayed key combination needs to match the user's platform.

Proposed change

  • Append the global-search shortcut to the composer placeholder.
  • Show ⌘K on macOS and Ctrl+K on Windows and Linux.
  • Cover all three platform values with an interaction test and align the renderer owner documentation.

Scope and non-goals

This only changes the placeholder copy and its platform-specific presentation. It does not change the existing global-search command, keyboard handling, architecture, or data model.

Acceptance criteria and validation

All checks listed below ran against the final rebased state:

  • Platform-specific placeholder behavior -> npm test -- --run src/renderer/src/pages/workspace/ConversationPanel.interaction.test.tsx -> 48 tests passed.
  • Renderer and shared type safety -> npm run typecheck -> passed.
  • Repository lint rules -> npm run lint -> passed with 0 errors and 18 pre-existing warnings.
  • Repository regression suite -> npm test -> 10,072 tests passed and 184 skipped across 690 passed and 15 skipped files.

Uncovered risk: the placeholder was not visually snapshot-tested at every window width; existing responsive text truncation behavior remains unchanged.

Review focus

Please verify the platform mapping and user-facing wording.

@github-actions github-actions Bot added the enhancement New feature or request label Aug 3, 2026
@ewen-poch
ewen-poch marked this pull request as ready for review August 3, 2026 05:49
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: No concrete merge-blocking defect found. Branch and pull request title checks are valid.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 3, 2026
@ewen-poch
ewen-poch merged commit 0ad1928 into main Aug 3, 2026
27 of 33 checks passed
@ewen-poch
ewen-poch deleted the feat/platform-search-placeholder branch August 3, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready-to-merge All completed AI reviewers found this pull request mergeable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant