Fix chunking algo for surrogate pairs #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elihart
approved these changes
Jan 27, 2026
renovate bot
added a commit
to keelim/all
that referenced
this pull request
Jan 29, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [com.airbnb:deeplinkdispatch-processor](https://redirect.github.com/airbnb/deeplinkdispatch) | `7.2.1` → `7.2.2` |  |  | | [com.airbnb:deeplinkdispatch](https://redirect.github.com/airbnb/deeplinkdispatch) | `7.2.1` → `7.2.2` |  |  | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>airbnb/deeplinkdispatch (com.airbnb:deeplinkdispatch-processor)</summary> ### [`v7.2.2`](https://redirect.github.com/airbnb/DeepLinkDispatch/releases/tag/7.2.2): DeepLinkDispatch v7.2.2 [Compare Source](https://redirect.github.com/airbnb/deeplinkdispatch/compare/7.2.1...7.2.2) ##### What's Changed - Update AGP to 8.13.2 by [@​rossbacher](https://redirect.github.com/rossbacher) in [airbnb/DeepLinkDispatch#385](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/385) - Optimize chunkOnModifiedUtf8ByteSize from O(n²) to O(n) by [@​Nepomuk5665](https://redirect.github.com/Nepomuk5665) in [airbnb/DeepLinkDispatch#386](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/386) - Upgrade GitHub Actions for Node 24 compatibility by [@​salmanmkc](https://redirect.github.com/salmanmkc) in [airbnb/DeepLinkDispatch#390](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/390) - Centralize toolchain and target compatibility version. by [@​rossbacher](https://redirect.github.com/rossbacher) in [airbnb/DeepLinkDispatch#388](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/388) - Fix chunking algo for surrogate pairs by [@​rossbacher](https://redirect.github.com/rossbacher) in [airbnb/DeepLinkDispatch#389](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/389) ##### New Contributors - [@​Nepomuk5665](https://redirect.github.com/Nepomuk5665) made their first contribution in [airbnb/DeepLinkDispatch#386](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/386) - [@​salmanmkc](https://redirect.github.com/salmanmkc) made their first contribution in [airbnb/DeepLinkDispatch#390](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/390) **Full Changelog**: <airbnb/DeepLinkDispatch@7.2.1...7.2.2> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/keelim/all). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi4xIiwidXBkYXRlZEluVmVyIjoiNDIuOTIuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOlsiVVBEQVRFLW1pbm9yLXBhdGNoIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #386 i realized that there is an issue with surrogate pairs which might be split by the current algo. they should be rare as they normally do not show up in URLs and in function and class names but they could.
I had Claude write the fix and upate the tests.