Skip to content

Opt/saving files#198

Merged
ipmach merged 11 commits into
developmentfrom
opt/saving_files
Jul 17, 2026
Merged

Opt/saving files#198
ipmach merged 11 commits into
developmentfrom
opt/saving_files

Conversation

@ipmach

@ipmach ipmach commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description

Optimization of To class. Before saving parsed logs or alerts could slow because the class was loading and saving to memory multiple times. Now it allows to only do it once or a smaller amount of times.

Checklist

  • This Pull-Request goes to the development branch.
  • I have successfully run prek locally.
  • I have added tests to cover my changes.
  • I have linked the issue-id to the task-description.
  • I have performed a self-review of my own code.

Base automatically changed from development to main July 6, 2026 11:04
Copilot AI requested a review from viktorbeck98 July 6, 2026 11:06
Comment thread src/detectmatelibrary/helper/from_to.py Dismissed
Comment thread src/detectmatelibrary/helper/from_to.py Dismissed
Comment thread src/detectmatelibrary/helper/from_to.py Dismissed
Comment thread src/detectmatelibrary/helper/from_to.py Dismissed
Comment thread src/detectmatelibrary/helper/from_to.py Dismissed
Comment thread src/detectmatelibrary/helper/from_to.py Dismissed
return func(*args, **kwargs)
else:
aux = func(*args, **kwargs)
return aux[0] if aux is not None else None

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that a bit fragile?

@viktorbeck98
viktorbeck98 changed the base branch from main to development July 6, 2026 11:54
Base automatically changed from development to main July 10, 2026 11:12
@ipmach
ipmach changed the base branch from main to development July 17, 2026 06:57
@ipmach
ipmach merged commit c5c7198 into development Jul 17, 2026
4 checks passed
@ipmach
ipmach deleted the opt/saving_files branch July 17, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants