Skip to content

docs(inkless): fix relation with kips on client-az awareness#485

Merged
giuseppelillo merged 2 commits intomainfrom
jeqo/fix-client-az-kip-ref
Jan 19, 2026
Merged

docs(inkless): fix relation with kips on client-az awareness#485
giuseppelillo merged 2 commits intomainfrom
jeqo/fix-client-az-kip-ref

Conversation

@jeqo
Copy link
Copy Markdown
Contributor

@jeqo jeqo commented Jan 19, 2026

This is missing that KIP-1123 it's only adding client.rack to the configs, but not the metadata request.
For that, KIP-1181 is needed.

This is missing that KIP-1123 it's only adding client.rack to the
configs, but not the metadata request.
For that, KIP-1181 is needed.
@jeqo jeqo marked this pull request as ready for review January 19, 2026 10:48
@jeqo jeqo requested a review from giuseppelillo January 19, 2026 10:48
@jeqo
Copy link
Copy Markdown
Contributor Author

jeqo commented Jan 19, 2026

@giuseppelillo a quick fix follow-up as I misunderstood the impact of KIP-1123, PTAL

- ⚠️ Non-standard approach, requires user awareness

### Future State (KIP-1123)
### Future State (KIP-1181)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU we are going to close this one and the changes are included into KIP-1163

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch. I'll update the references to KIP-1163 then

@jeqo jeqo requested a review from AnatolyPopov January 19, 2026 11:12
Copy link
Copy Markdown
Contributor

@AnatolyPopov AnatolyPopov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @giuseppelillo do you want to take a look as well before merging?

@giuseppelillo giuseppelillo merged commit 76f7f96 into main Jan 19, 2026
5 checks passed
@giuseppelillo giuseppelillo deleted the jeqo/fix-client-az-kip-ref branch January 19, 2026 14:23
giuseppelillo pushed a commit that referenced this pull request Jan 27, 2026
* docs(inkless): fix relation with kips on client-az awareness

This is missing that KIP-1123 it's only adding client.rack to the
configs, but not the metadata request.
For that, KIP-1181 is needed.

* fixup! docs(inkless): fix relation with kips on client-az awareness
giuseppelillo pushed a commit that referenced this pull request Jan 27, 2026
* docs(inkless): fix relation with kips on client-az awareness

This is missing that KIP-1123 it's only adding client.rack to the
configs, but not the metadata request.
For that, KIP-1181 is needed.

* fixup! docs(inkless): fix relation with kips on client-az awareness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants