docs(inkless): fix relation with kips on client-az awareness#485
Merged
giuseppelillo merged 2 commits intomainfrom Jan 19, 2026
Merged
docs(inkless): fix relation with kips on client-az awareness#485giuseppelillo merged 2 commits intomainfrom
giuseppelillo merged 2 commits intomainfrom
Conversation
This is missing that KIP-1123 it's only adding client.rack to the configs, but not the metadata request. For that, KIP-1181 is needed.
Contributor
Author
|
@giuseppelillo a quick fix follow-up as I misunderstood the impact of KIP-1123, PTAL |
| - ⚠️ Non-standard approach, requires user awareness | ||
|
|
||
| ### Future State (KIP-1123) | ||
| ### Future State (KIP-1181) |
Contributor
There was a problem hiding this comment.
AFAIU we are going to close this one and the changes are included into KIP-1163
Contributor
Author
There was a problem hiding this comment.
Ah good catch. I'll update the references to KIP-1163 then
AnatolyPopov
approved these changes
Jan 19, 2026
Contributor
AnatolyPopov
left a comment
There was a problem hiding this comment.
LGTM. @giuseppelillo do you want to take a look as well before merging?
giuseppelillo
approved these changes
Jan 19, 2026
giuseppelillo
pushed a commit
that referenced
this pull request
Jan 27, 2026
* docs(inkless): fix relation with kips on client-az awareness This is missing that KIP-1123 it's only adding client.rack to the configs, but not the metadata request. For that, KIP-1181 is needed. * fixup! docs(inkless): fix relation with kips on client-az awareness
giuseppelillo
pushed a commit
that referenced
this pull request
Jan 27, 2026
* docs(inkless): fix relation with kips on client-az awareness This is missing that KIP-1123 it's only adding client.rack to the configs, but not the metadata request. For that, KIP-1181 is needed. * fixup! docs(inkless): fix relation with kips on client-az awareness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is missing that KIP-1123 it's only adding client.rack to the configs, but not the metadata request.
For that, KIP-1181 is needed.