Allow switching diskless.enable from false to true#486
Merged
Conversation
`diskless.enable` for a topic can be switched from false to true, only if `diskless.migration.enable` is enabled.
jeqo
reviewed
Jan 21, 2026
server-common/src/main/java/org/apache/kafka/server/config/ServerConfigs.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
Outdated
Show resolved
Hide resolved
`diskless.allow.from.classic.enable`
jeqo
reviewed
Jan 22, 2026
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Added a new commit to clean up the logic, allowing config updates and considering the cases where a classic topic does not have diskless.enable set to false. |
jeqo
reviewed
Jan 23, 2026
Contributor
jeqo
left a comment
jeqo
left a comment
There was a problem hiding this comment.
Just a final suggestion on the LogConfig validation for diskless to make it a bit more readable and have more explicit error messages. Apart from that, LGTM.
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
Show resolved
Hide resolved
jeqo
requested changes
Jan 26, 2026
Contributor
jeqo
left a comment
jeqo
left a comment
There was a problem hiding this comment.
LGTM @giuseppelillo, just a minor error on my suggestion to be fixed before merging. Thanks!
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
Outdated
Show resolved
Hide resolved
jeqo
approved these changes
Jan 26, 2026
giuseppelillo
added a commit
that referenced
this pull request
Jan 27, 2026
`diskless.enable` for a topic can be switched from false to true, only if `diskless.migration.enable` is enabled
giuseppelillo
added a commit
that referenced
this pull request
Jan 27, 2026
`diskless.enable` for a topic can be switched from false to true, only if `diskless.migration.enable` is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diskless.enablefor a topic can be switched from false to true, only ifdiskless.migration.enableis enabled.