bugfix: raise error in check_version if broker is unavailable #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue in check_version where KeyError is raised if the broker is unavailable or an invalid node_id is used. Instead it will return BrokerNotAvailableError.
aiven-anton
reviewed
Feb 23, 2024
Comment on lines
+914
to
+915
| if not self._maybe_connect(try_node): | ||
| raise Errors.BrokerNotAvailableError() |
There was a problem hiding this comment.
note (non-blocking): This looks correct, and like it should eliminate the chance of a KeyError on the next line.
The _maybe_connect method only returns True if try_node exists in self._conns. I notice there's also locking in that method, indicating there's concurrency and potentially a race condition where the node could be deleted from self._conns with bad timing. I'd be surprised if such a scenario isn't exceedingly rare, and I think this fix is sufficient.
aiven-anton
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in check_version where KeyError is raised if the broker is unavailable or an invalid node_id is used. Instead it will return BrokerNotAvailableError.