preflight checks the four adopter-set values and names their section - #123
Merged
Conversation
Nothing checked these until a real run failed, and the one thing that did check was deleted at the end of install: the self-test names the section on a miss, then init tells the adopter to delete it. Two of the four live under Variables and two under Secrets, and a value filed on the wrong tab reads back empty rather than erroring. That is not hypothetical; it happened during a real install and was found by reading the caller workflow. A shared requireSet gives every message the same shape and names the tab. Whitespace counts as empty, since that is what a wrong-tab value looks like from here. The App pair is only checked with --actions, which the reusable workflow now passes. A local run authenticates as the operator and never uses them, so requiring them there would fail a working setup. A configuration miss exits 3. It is something to go and set, not a bug to report, and a caller should not have to match on message text to tell. Closes #115
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115.
Nothing checked these until a real run failed, and the one thing that did check was deleted at the end of install: the self-test names the section on a miss, then
inittells the adopter to delete it.The change
A shared
requireSetgives every message the same shape and names the tab:--actions, which the reusable workflow now passes in both jobs. A local run authenticates as the operator and never uses those, so requiring them there would fail a working setup.Tests
Each of the four values, unset, asserts the error names both the value and its section. Plus: whitespace treated as unset, a local run not requiring the App pair, and exit 3 rather than 1.
Provenance
The agent designed this on #115 and blocked because the fix needs
.github/workflows/simplycubed.yml, which the App cannot push. Its escalation named the file — the first run to benefit from #120. I took its approach.Gate green with all four values unset.