Prepare v0.3.0 - #132
Merged
Merged
Conversation
Comment commands address the adopter's own App. v0.2.0's fixed prefix fixed the multi-tenant bug and gave up GitHub's autocomplete, which only offers accounts with repository access and is the whole reason a handle beats a prefix. Also fixes the release check itself: it matched the Go version pin as a fixed string, so gofmt realigning that constant made it fail on this very release. A check a formatter can invalidate is worse than none.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release prep for the App-handle work in #131.
Breaking
.github/simplycubed.ymlgains a requiredappName:,simplycubed initrequires--app-name, and the comment prefix changes from/simplycubed <verb>to@<your-app> <verb>. Adopters re-runsimplycubed init --workflow --app-name <your-app>.Second breaking release in a day, which is worth naming: v0.2.0 changed the prefix to
/simplycubedand that turned out to be the wrong call. Pre-1.0 and one known install, so the cost is a re-run ofinit.A bug in the release check itself
verify-release.shmatched the Go version pin withgrep -F— a fixed string. #131 added a second constant to that block, gofmt realigned both, and the check then failed on the very release it exists to guard:The pin was correct; the matcher was brittle. It now uses
grep -Ewith[[:space:]]*, so gofmt cannot invalidate it. Confirmed the guard still fails on a wrong version:After merging
Cut the tag with the tag-release workflow, then corp#65 needs redoing against v0.3.0 — it currently targets v0.2.0 and
/simplycubed.