Read the Go version from go.mod in this repo's own workflows - #144
Merged
Conversation
check, release, and tag-release pinned a floating "1.26" in five places; they now read go.mod, which carries a toolchain directive at go1.26.5, so a patch bump is one line. The reusable workflow keeps the floating constraint on purpose and now says why: it sets up Go in the adopter's checkout, where go-version-file would read their go.mod, not ours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same consolidation as aixgo-dev/aixgo#239 and aixgo-dev/aixgate#12: the Go patch version lives in go.mod's new
toolchain go1.26.5directive (latest stable), and check/release/tag-release read it viago-version-file. The one-entry version matrices are gone (checks-passaggregates by job id, so the required check is unaffected).The reusable workflow (aixgo.yml) deliberately keeps its floating
go-version: "1.26"and now carries a comment explaining why: it runs in the adopter's checkout, wherego-version-filewould read the adopter's go.mod rather than ours.make checkgreen, including the workflow validation gate.