Keep main up-to-date with latest nightly improvements#60
Merged
Conversation
Use poach-benchmarks for nightly
Extract toolchain update + benchmarks clone into infra/setup.sh, and have nightly.sh skip that setup when run by the combined-nightly orchestrator (which sets POACH_NIGHTLY_COMBINED=1 and supplies POACH_BENCHMARKS_DIR). Standalone behavior is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
When the combined-nightly orchestrator runs this branch in a worktree, it passes POACH_BENCHMARKS_DIR pointing at a shared clone above the worktree (so we don't re-clone per branch). The benchmark_root.relative_to(REPO_ROOT) call then raises ValueError. Add display_path() that falls back to the absolute path when the input isn't a subpath of REPO_ROOT. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Emit benchmark_path relative to the suite's train/ subdir (matching the serialize branch's convention) so the combined-nightly comparison table can join rows by benchmark_path without the orchestrator having to strip the prefix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Match the serialize branch exactly so the combined-nightly merger can join rows by benchmark_path with no normalization. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Serialize emits `<name>.egg`, not `<name>` — the previous edit over-corrected.
Drop the .with_suffix("") so vanilla and serialize both emit `<name>.egg`
and the merger joins rows correctly.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Nightly for Vanilla Egglog
Better time displays
refactor nightly
FTRobbin
commented
May 18, 2026
| #!/usr/bin/env python3 | ||
|
|
||
| from __future__ import annotations | ||
| #!/user/bin/env python3 |
Owner
There was a problem hiding this comment.
Oops, this looks like a mistake. Should be #!/usr/bin/env python3
| } catch (error) { | ||
| const response = await fetch("./data/data.json"); | ||
| if (!response.ok) { | ||
| statusNode.textContent = `Failed to load data/data.json: ${error}`; |
Collaborator
Author
There was a problem hiding this comment.
error seems undefined.
Owner
There was a problem hiding this comment.
oops, good catch. We can do statusNode.textContent = Failed to load data/data.json: ${response.status} ${response.statusText};
ajpal
approved these changes
May 18, 2026
ajpal
left a comment
ajpal
left a comment
Owner
There was a problem hiding this comment.
thanks for porting this back up!
| } catch (error) { | ||
| const response = await fetch("./data/data.json"); | ||
| if (!response.ok) { | ||
| statusNode.textContent = `Failed to load data/data.json: ${error}`; |
Owner
There was a problem hiding this comment.
oops, good catch. We can do statusNode.textContent = Failed to load data/data.json: ${response.status} ${response.statusText};
| #!/usr/bin/env python3 | ||
|
|
||
| from __future__ import annotations | ||
| #!/user/bin/env python3 |
Owner
There was a problem hiding this comment.
Oops, this looks like a mistake. Should be #!/usr/bin/env python3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: generic updates to the nightly should ideally be first pushed to main, then downstream to algorithm branches. We hacked directly on
Vanillathis time, should explain sooner.The workflow should be like this:
In the beginning:
I hacked on algo 1 and improved the nightly there.
Let me factor out the generic parts that can be reused.
Now the other algorithm branches can pull from main to benefit from the improvement, and the diffs show only the algorithm-specific changes.