fix(dfu): harden flash_beacon.sh with timeouts + retries#15
Merged
Conversation
mcumgr was previously called with no timeout flags and no wall-clock
cap. A stuck SMP transfer (BLE link drop, MTU stall, peer reboot
mid-upload) would hang the script indefinitely with no useful output.
Hardening:
- set -euo pipefail (script previously continued past a failed upload
to image confirm, which would confirm against potentially stale state)
- mcumgr -t 5 -r 5 on every call: 5s per-RPC timeout, 5 retries per
packet — covers transient MTU/link issues without masking a real hang
- timeout 300s wall-clock cap on the upload step (SIGTERM, then SIGKILL
after 10s grace) — 200 KB image at MTU 498 is 30-90s in practice
- MCUMGR env var with sane fallback (was hardcoded to ~/go/bin/mcumgr)
- UPLOAD_TIMEOUT env var for tuning
- bash array variables for connection args (eliminates shell-quoting
fragility around the connstring)
- Argument validation refactored to use ${VAR:-} so unset args fail
cleanly under set -u
- sudo -v to prime the credential cache (was: sudo echo "")
- shellcheck clean
Behavior on success is unchanged. Failure modes that previously hung
silently now exit non-zero with a clear cause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mcumgr was previously called with no timeout flags and no wall-clock
cap. A stuck SMP transfer (BLE link drop, MTU stall, peer reboot
mid-upload) would hang the script indefinitely with no useful output.
Hardening:
to image confirm, which would confirm against potentially stale state)
packet — covers transient MTU/link issues without masking a real hang
after 10s grace) — 200 KB image at MTU 498 is 30-90s in practice
fragility around the connstring)
cleanly under set -u
Behavior on success is unchanged. Failure modes that previously hung
silently now exit non-zero with a clear cause.