feat(deployment): create IP endpoints in the expose ports modal - #3385
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
💤 Files with no reviewable changes (8)
📝 WalkthroughWalkthroughThe PR adds inline creation and validation of IP endpoints in the expose-port configuration flow, removes the separate IP endpoints pane, and updates SDL generation/import so endpoints are emitted only when referenced by a service expose entry. ChangesIP endpoint flow
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3385 +/- ##
==========================================
- Coverage 69.80% 68.43% -1.37%
==========================================
Files 1100 1010 -90
Lines 26915 24577 -2338
Branches 6453 5992 -461
==========================================
- Hits 18787 16819 -1968
+ Misses 7134 6796 -338
+ Partials 994 962 -32
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
ygrishajev
enabled auto-merge
July 2, 2026 12:37
A port's Routing control now offers "+ New IP endpoint", revealing an inline name input that is committed on Save and bound to that port. Endpoints created this way stay selectable by other services. The generator emits only endpoints a port actually references, so an unused endpoint is dropped from the SDL instead of failing the deploy. Removes the standalone IP Endpoints section from the deployment pane.
ygrishajev
force-pushed
the
feat/deployment-ip-endpoints-in-expose-modal
branch
from
July 2, 2026 12:42
30862f7 to
4dcd87b
Compare
baktun14
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes CON-619
Part of CON-411
An IP endpoint (a dedicated public IP for a deployment) used to be declared in a
standalone section, disconnected from the service that would use it. That made it easy
to declare an endpoint no service referenced — and an unused IP endpoint is rejected by
the Akash SDL parser, so the deploy failed with a confusing error instead of the problem
being prevented up front.
What
Moves IP endpoint creation into a service port's Routing control in the Expose Ports modal:
reveals an inline name input (no separate add/cancel buttons). The name is committed on
Save and the port is bound to the endpoint immediately; saving with an empty name is
blocked with an inline error.
dropped from the SDL instead of failing the deploy (this replaces the short-lived
"unused endpoint" validation error).
Tests included: endpoint-name validation (empty / format / uniqueness); generator drops
unused and emits referenced endpoints; SDL import round-trips a referenced endpoint;
deployment-pane specs updated.
Notes
selectable endpoints from port usage and drop the now-redundant endpoints list.
error, unused-dropped-from-SDL) were added to the shared configure-deployment walkthrough
spec, which is tracked separately and not part of this commit.
Screen.Recording.2026-07-02.at.14.15.00.mov
Summary by CodeRabbit
New Features
Bug Fixes