feat(deployment): edit manifest fields while quotes are live - #3390
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (28)
📝 WalkthroughWalkthroughThis PR refines which configuration cards are locked when a deployment already exists on-chain: runtime, ports, and logs cards stay locked while image, environment variables, and commands cards remain editable. ChangesLock prop refinement and lock indicator UI
Estimated code review effort: 3 (Moderate) | ~25 minutes Pre-lease Deployment Manifest Update
Estimated code review effort: 4 (Complex) | ~40 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
aa6cc2b to
657db2a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3390 +/- ##
==========================================
- Coverage 70.00% 68.66% -1.34%
==========================================
Files 1102 1012 -90
Lines 27030 24697 -2333
Branches 6477 6019 -458
==========================================
- Hits 18923 16959 -1964
+ Misses 7116 6785 -331
+ Partials 991 953 -38
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
657db2a to
0f2cce1
Compare
0f2cce1 to
bbe6548
Compare
After quotes are requested, only the fields that can't change on-chain lock (compute resources, pricing, placement, replicas, ports); the image, environment variables and commands stay editable. Deploying after such an edit updates the deployment before creating the lease, so the provider receives the edited manifest and the already-returned bids stay valid.
bbe6548 to
ed11fa1
Compare
2 participants
Why
Fixes CON-631
On the redesigned Configure screen, requesting quotes locked the entire configuration. Changing
even a minor manifest detail — a container image tag, an environment variable, the start
command — meant using "Cancel & edit", which discarded the deployment and every quote already
returned and forced a full re-quote. Those edits don't change the resources, price or placement
that providers bid on, so the existing quotes stay valid — users should be able to make them in
place and deploy without starting over.
What
While quotes are live (after "Request quotes", before "Deploy"):
header: compute resources, GPU, storage, replicas, pricing, placement/region, exposed ports,
logs, reclamation. The lock banner now reads "Changing a locked setting needs new quotes."
On Deploy, when the manifest changed since the deployment was created, the deployment is
updated on-chain before the lease is created, so the provider receives the edited manifest and
the already-returned bids remain valid. When nothing changed, deploy goes straight to the lease.
This also removes a latent issue where deploy reused the create-time manifest and would have
silently dropped a quoting-window edit.
Verified end-to-end against the managed API: create → poll bids → update (manifest-only change)
→ create lease reusing a pre-update bid; the provider accepted the updated manifest.
Testing
useDeploymentFlow(updates before leasing only when the manifest changed,otherwise leases directly; returns to quoting on a failed update),
ConfigurationPane/AdditionalSection(image/env/commands stay editable while the rest lock),CollapsibleCard(lock glyph),
PaneLockBanner(copy).configure-deployment-flow): after "Request quotes" the Docker image stays editablewhile CPU is disabled, and the lock banner shows the new copy.
Screen.Recording.2026-07-07.at.10.22.08.mov
Summary by CodeRabbit
New Features
Bug Fixes