test: fixes e2e tests for notification channels - #3407
Merged
Conversation
stalniy
marked this pull request as ready for review
July 10, 2026 09:17
stalniy
enabled auto-merge
July 10, 2026 09:17
Contributor
📝 WalkthroughWalkthroughChangesNotification channel UI verification
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3407 +/- ##
==========================================
- Coverage 71.51% 70.85% -0.67%
==========================================
Files 1110 1060 -50
Lines 28131 26820 -1311
Branches 7013 6717 -296
==========================================
- Hits 20119 19002 -1117
+ Misses 7027 6853 -174
+ Partials 985 965 -20
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/deploy-web/tests/ui/pages/NotificationChannelsPage.ts`:
- Around line 32-35: Replace the immediate isVisible() check in the pagination
handling logic with an explicit Playwright wait for the pagination navigation to
become visible, using a short timeout and catching timeout errors to return when
pagination is genuinely absent. Ensure the fallback preserves the current
early-return behavior while allowing slow-rendering pagination to be detected.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 381a7abd-07fb-4041-b353-99760c1246b7
📒 Files selected for processing (2)
apps/deploy-web/tests/ui/managed-wallet-notification-channels.spec.tsapps/deploy-web/tests/ui/pages/NotificationChannelsPage.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
this tests are broken now
What
Summary by CodeRabbit