test(deployment): guard the legacy deploy-linux e2e behind the onboarding redesign flag - #3450
Conversation
…ding redesign flag Since #3443, /deploy-linux redirects to /new-deployment/configure?vm=true when onboarding_redesign_v1 is on (as in beta), where the OS selector is a "Distribution" combobox instead of the legacy "OS image" one, so the spec timed out in the "Test beta (NA)" e2e job. Add the skipIfOnboardingRedesign guard the sibling legacy builder specs already use so it skips where the redesign is live and still runs where the flag is off.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Linux deployment UI spec imports ChangesLinux deployment UI test
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3450 +/- ##
==========================================
- Coverage 72.92% 71.82% -1.10%
==========================================
Files 1170 1080 -90
Lines 29665 27319 -2346
Branches 7363 6909 -454
==========================================
- Hits 21632 19623 -2009
+ Misses 7064 6757 -307
+ Partials 969 939 -30
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Why
The
Deploy App→Test beta (NA) / Test staginge2e job started failing on the first run after #3443 merged tomain.tests/ui/deploy-linux.spec.tsdrives the legacy/deploy-linuxbuilder and clicks the "OS image" combobox (PlainLinuxPage.tsx:6). #3443 makes/deploy-linuxredirect to/new-deployment/configure?vm=truewhenonboarding_redesign_v1is on (it is on in beta), where that selector is a "Distribution" combobox instead, so the click times out:deploy-linux.spec.tsis the only legacy builder spec that #3443's redirect superseded without adding theskipIfOnboardingRedesignguard its siblings already use (managed-wallet-deployment.spec.ts,managed-wallet-onboarding.spec.ts).Ref CON-675 (already closed by #3443; this fixes the e2e fallout).
What
Add a module-level
beforeEachtodeploy-linux.spec.tscalling the existingskipIfOnboardingRedesignhelper, mirroring the sibling legacy specs. No production code changes.Porting the VM/SSH e2e to the new configure flow is deferred as a follow-up (tracked in CON-685), as #3443 stated.