Skip to content

test(deployment): guard the legacy deploy-linux e2e behind the onboarding redesign flag - #3450

Merged
baktun14 merged 1 commit into
mainfrom
test/deployment-guard-deploy-linux-e2e-flag
Jul 17, 2026
Merged

test(deployment): guard the legacy deploy-linux e2e behind the onboarding redesign flag#3450
baktun14 merged 1 commit into
mainfrom
test/deployment-guard-deploy-linux-e2e-flag

Conversation

@baktun14

@baktun14 baktun14 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Why

The Deploy AppTest beta (NA) / Test staging e2e job started failing on the first run after #3443 merged to main. tests/ui/deploy-linux.spec.ts drives the legacy /deploy-linux builder and clicks the "OS image" combobox (PlainLinuxPage.tsx:6). #3443 makes /deploy-linux redirect to /new-deployment/configure?vm=true when onboarding_redesign_v1 is on (it is on in beta), where that selector is a "Distribution" combobox instead, so the click times out:

[chromium] › tests/ui/deploy-linux.spec.ts:9:5 › ssh keys generation
  TimeoutError: locator.click: Timeout 15000ms exceeded.
  - waiting for getByRole('combobox', { name: /os image/i })

deploy-linux.spec.ts is the only legacy builder spec that #3443's redirect superseded without adding the skipIfOnboardingRedesign guard its siblings already use (managed-wallet-deployment.spec.ts, managed-wallet-onboarding.spec.ts).

Ref CON-675 (already closed by #3443; this fixes the e2e fallout).

What

Add a module-level beforeEach to deploy-linux.spec.ts calling the existing skipIfOnboardingRedesign helper, mirroring the sibling legacy specs. No production code changes.

  • Flag on (beta): the spec skips, matching every other superseded legacy flow, so the job goes green.
  • Flag off: the spec runs the legacy builder unchanged, preserving coverage until the legacy builder is retired.

Porting the VM/SSH e2e to the new configure flow is deferred as a follow-up (tracked in CON-685), as #3443 stated.

…ding redesign flag

Since #3443, /deploy-linux redirects to /new-deployment/configure?vm=true when
onboarding_redesign_v1 is on (as in beta), where the OS selector is a
"Distribution" combobox instead of the legacy "OS image" one, so the spec timed
out in the "Test beta (NA)" e2e job. Add the skipIfOnboardingRedesign guard the
sibling legacy builder specs already use so it skips where the redesign is live
and still runs where the flag is off.
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5f95b71f-42c4-45d5-a15b-4a88b9c74ab1

📥 Commits

Reviewing files that changed from the base of the PR and between 86030e6 and 3ef1a20.

📒 Files selected for processing (1)
  • apps/deploy-web/tests/ui/deploy-linux.spec.ts

📝 Walkthrough

Walkthrough

The Linux deployment UI spec imports skipIfOnboardingRedesign and invokes it in a test.beforeEach hook before each test runs.

Changes

Linux deployment UI test

Layer / File(s) Summary
Onboarding redesign setup
apps/deploy-web/tests/ui/deploy-linux.spec.ts
The spec applies skipIfOnboardingRedesign(page) before each test, preserving the existing SSH key generation assertions outside the onboarding redesign flow.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • akash-network/console#3443: Updates the /deploy-linux UI test to skip the onboarding redesign path when the feature flag is enabled.

Suggested labels: size: S

Suggested reviewers: ygrishajev

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/deployment-guard-deploy-linux-e2e-flag

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.82%. Comparing base (86030e6) to head (3ef1a20).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3450      +/-   ##
==========================================
- Coverage   72.92%   71.82%   -1.10%     
==========================================
  Files        1170     1080      -90     
  Lines       29665    27319    -2346     
  Branches     7363     6909     -454     
==========================================
- Hits        21632    19623    -2009     
+ Misses       7064     6757     -307     
+ Partials      969      939      -30     
Flag Coverage Δ *Carryforward flag
api 85.95% <ø> (ø) Carriedforward from 86030e6
deploy-web 62.01% <ø> (ø)
log-collector ?
notifications 91.44% <ø> (ø) Carriedforward from 86030e6
provider-console 81.38% <ø> (ø) Carriedforward from 86030e6
provider-inventory ?
provider-proxy 86.42% <ø> (ø) Carriedforward from 86030e6
tx-signer ?

*This pull request uses carry forward flags. Click here to find out more.
see 90 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: all changes are related to tests.

@baktun14
baktun14 added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit b8d616c Jul 17, 2026
57 checks passed
@baktun14
baktun14 deleted the test/deployment-guard-deploy-linux-e2e-flag branch July 17, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant