fix: prevent payment intent creation for unauthenticated user - #3462
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesStripe payment flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3462 +/- ##
==========================================
- Coverage 73.05% 72.21% -0.85%
==========================================
Files 1175 1111 -64
Lines 29797 27868 -1929
Branches 7404 7001 -403
==========================================
- Hits 21769 20124 -1645
+ Misses 7062 6807 -255
+ Partials 966 937 -29
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
baktun14
approved these changes
Jul 19, 2026
baktun14
added a commit
that referenced
this pull request
Jul 21, 2026
#3462 refactored StripeService from extractApiData (which unwrapped both the axios data and the API data envelope) to extractData (one level) and added a compensating .data to every method except getCustomerTransactions, which was left returning the still-wrapped { data: { transactions } }. The billing history table reads transactions one level too high, so it renders "No billing history found" even when the endpoint returns rows. Restore the .data unwrap and add a regression test that fails on the wrapped shape.
baktun14
added a commit
that referenced
this pull request
Jul 21, 2026
#3462 refactored StripeService from extractApiData (which unwrapped both the axios data and the API data envelope) to extractData (one level) and added a compensating .data to every method except getCustomerTransactions, which was left returning the still-wrapped { data: { transactions } }. The billing history table reads transactions one level too high, so it renders "No billing history found" even when the endpoint returns rows. Restore the .data unwrap and add a regression test that fails on the wrapped shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes CON-697
What
Summary by CodeRabbit