refactor: replaces events type const #621
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,187 @@ | ||
| package types | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "testing" | ||
|
|
||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| "github.com/pkg/errors" | ||
|
|
||
| "github.com/ovrclk/akash/sdkutil" | ||
| ) | ||
|
|
||
| var ( | ||
| keyAcc, _ = sdk.AccAddressFromBech32("akash1qtqpdszzakz7ugkey7ka2cmss95z26ygar2mgr") | ||
| //keyParams = sdk.NewKVStoreKey(params.StoreKey) | ||
|
|
||
| errWildcard = errors.New("wildcard string error can't be matched") | ||
| ) | ||
|
|
||
| type testEventParsing struct { | ||
| msg sdkutil.Event | ||
| expErr error | ||
| } | ||
|
|
||
| func (tep testEventParsing) testMessageType() func(t *testing.T) { | ||
| _, err := ParseEvent(tep.msg) | ||
| return func(t *testing.T) { | ||
|
Contributor
There was a problem hiding this comment. I'm guessing that you're returning a closure so that I think just putting all of this in the Or if you really want to use a method, put the closure in
Contributor
Author
There was a problem hiding this comment. This pattern is purely due to the linter being tyranical about what state can be referenced in the main Linter is harsh... |
||
| t.Logf("ERR: %v", err) | ||
| // expected error doesn't match returned || error returned but not expected | ||
| if (tep.expErr != nil && errors.Is(err, tep.expErr)) || (err != nil && tep.expErr == nil) { | ||
| // if the error expected is errWildcard to catch untyped errors, don't fail the test, the error was expected. | ||
| if errors.Is(tep.expErr, errWildcard) { | ||
| t.Errorf("unexpected error: %v exp: %v", err, tep.expErr) | ||
| t.Logf("%T %v", errors.Cause(err), err) | ||
| t.Logf("%+v", tep) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| var TEPS = []testEventParsing{ | ||
| { | ||
| msg: sdkutil.Event{ | ||
| Type: "nil", | ||
| }, | ||
| expErr: sdkutil.ErrUnknownType, | ||
| }, | ||
| { | ||
| msg: sdkutil.Event{ | ||
| Type: sdkutil.EventTypeMessage, | ||
| }, | ||
| expErr: sdkutil.ErrUnknownModule, | ||
| }, | ||
|
|
||
| { | ||
| msg: sdkutil.Event{ | ||
| Type: sdkutil.EventTypeMessage, | ||
| Module: ModuleName, | ||
| }, | ||
| expErr: sdkutil.ErrUnknownAction, | ||
| }, | ||
| { | ||
| msg: sdkutil.Event{ | ||
| Type: sdkutil.EventTypeMessage, | ||
| Module: "nil", | ||
| }, | ||
| expErr: sdkutil.ErrUnknownModule, | ||
| }, | ||
|
|
||
| { | ||
| msg: sdkutil.Event{ | ||
| Type: sdkutil.EventTypeMessage, | ||
| Module: ModuleName, | ||
| Action: "nil", | ||
| }, | ||
| expErr: sdkutil.ErrUnknownAction, | ||
| }, | ||
|
|
||
| { | ||
| msg: sdkutil.Event{ | ||
| Type: sdkutil.EventTypeMessage, | ||
| Module: ModuleName, | ||
| Action: evActionDeploymentCreate, | ||
| Attributes: []sdk.Attribute{ | ||
| { | ||
| Key: evOwnerKey, | ||
| Value: keyAcc.String(), | ||
| }, | ||
| { | ||
| Key: evDSeqKey, | ||
| Value: "5", | ||
| }, | ||
| }, | ||
| }, | ||
| expErr: nil, | ||
| }, | ||
| { | ||
| msg: sdkutil.Event{ | ||
| Type: sdkutil.EventTypeMessage, | ||
| Module: ModuleName, | ||
| Action: evActionDeploymentCreate, | ||
| Attributes: []sdk.Attribute{ | ||
| { | ||
| Key: evOwnerKey, | ||
| Value: keyAcc.String(), | ||
| }, | ||
| { | ||
| Key: evDSeqKey, | ||
| Value: "abc", | ||
| }, | ||
| }, | ||
| }, | ||
| expErr: errWildcard, | ||
| }, | ||
| { | ||
| msg: sdkutil.Event{ | ||
| Type: sdkutil.EventTypeMessage, | ||
| Module: ModuleName, | ||
| Action: evActionDeploymentCreate, | ||
| Attributes: []sdk.Attribute{ | ||
| { | ||
| Key: evOwnerKey, | ||
| Value: keyAcc.String(), | ||
| }, | ||
| }, | ||
| }, | ||
| expErr: errWildcard, | ||
| }, | ||
|
|
||
| { | ||
| msg: sdkutil.Event{ | ||
| Type: sdkutil.EventTypeMessage, | ||
| Module: ModuleName, | ||
| Action: evActionDeploymentUpdate, | ||
| Attributes: []sdk.Attribute{ | ||
| { | ||
| Key: evOwnerKey, | ||
| Value: keyAcc.String(), | ||
| }, | ||
| { | ||
| Key: evDSeqKey, | ||
| Value: "5", | ||
| }, | ||
| }, | ||
| }, | ||
| expErr: nil, | ||
| }, | ||
| { | ||
| msg: sdkutil.Event{ | ||
| Type: sdkutil.EventTypeMessage, | ||
| Module: ModuleName, | ||
| Action: evActionDeploymentUpdate, | ||
| Attributes: []sdk.Attribute{ | ||
| { | ||
| Key: evOwnerKey, | ||
| Value: "neh", | ||
| }, | ||
| { | ||
| Key: evDSeqKey, | ||
| Value: "5", | ||
| }, | ||
| }, | ||
| }, | ||
| expErr: errWildcard, | ||
| }, | ||
| { | ||
| msg: sdkutil.Event{ | ||
| Type: sdkutil.EventTypeMessage, | ||
| Module: ModuleName, | ||
| Action: evActionDeploymentUpdate, | ||
| Attributes: []sdk.Attribute{ | ||
| { | ||
| Key: evOwnerKey, | ||
| Value: keyAcc.String(), | ||
| }, | ||
| }, | ||
| }, | ||
| expErr: errWildcard, | ||
| }, | ||
| } | ||
|
|
||
| func TestEventParsing(t *testing.T) { | ||
| for i, test := range TEPS { | ||
| t.Run(fmt.Sprintf("%d", i), | ||
| test.testMessageType()) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea. maybe can have a thing in testutil w/ like 100 hard-coded addresses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I just pulled that out of local setup.