perf: remove provider transaction event subscription - #622
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
==========================================
+ Coverage 22.09% 22.13% +0.03%
==========================================
Files 127 127
Lines 6353 6342 -11
==========================================
Hits 1404 1404
+ Misses 4872 4861 -11
Partials 77 77
Continue to review full report at Codecov.
|
| return cmd | ||
| } | ||
|
|
||
| // doRunCmd initializes all of the Provider functionality, hangs, and awaits shutdown signals. |
boz
approved these changes
May 28, 2020
boz
left a comment
boz
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thank you!
One comment inline.
* Deactivated events.Publish subscribes to the tendermint event bus
and re-published events to the rest of the provider/
modules.
fixes #606
Signed-off-by: Josh Roppo <josh@akash.network>
Ropes
force-pushed
the
ropes/events-cleanup
branch
from
May 29, 2020 16:55
ac388a0 to
10920b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and re-published events to the rest of the provider/
modules.
fixes #606