Bind a pluggable text template's contentparams, and report editable where Mendix has none (#928)

[ako]

Fixes both bugs in upstream #928. They turned out to be one bug wearing two hats.

The shared cause

isBuiltinPropName (mdl/executor/widget_engine.go) is a single flat list holding both ContentParams and Editable, and it backs both validators — MDL-WIDGET01 (pluggable) and MDL-WIDGET07 (static). It answers "is this a real MDL property name anywhere?", and both validators read it as "is this valid on this widget?". The engine then acts on each keyword only for the widget kinds that support it, and drops the rest in silence.

Bug 1 — fixed

One correction to the report: it is the first write, not the round-trip. No describe needed.

CE0720  "Place holder index 1 is greater than 0, the number of parameter(s)." at Image 'cardImage'

The stored BSON localises it — same page, two widgets, same syntax:

widget	stored ClientTemplate
dynamictext (control)	Text='{1}', Parameters=[2, {ClientTemplateParameter…}]
Image imageUrl	Text='{1}', Parameters=[2] ← empty

The engine took the parameters path only for mxcli's {AttrName} convenience spelling, so Mendix's own numeric {1} form had no route at all. Both spellings now reach the same stored shape via a new SetTextTemplateWithClientParams on the builder interface and both implementations. After the fix the Image's template holds one parameter bound to Product.PictureUrl — identical to the control — and mx check is 0 errors.

Worth relaying to the reporter: imageUrl: '{PictureUrl}' already works on v0.18.0 and is an immediate workaround. The capability was never missing; only the {1} + contentparams: spelling had no route.

Bug 2 — cannot be implemented as asked, so it is now reported

The issue asks for editable: → Editability/ConditionalEditabilitySettings on a button. There is no such field:

• PagesActionButton has ConditionalVisibilitySettings but no Editability and no ConditionalEditabilitySettings.
• Measured across generated/metamodel: exactly 11 Pages types carry editability — CheckBox, DataView, DatePicker, DropDown, FileManager, ImageUploader, InputReferenceSetSelector, RadioButtonGroup, ReferenceSelector, TextArea, TextBox — and none of the 14 button types does.

A button has conditional visibility, not editability. So the issue's own second option is the correct one: MDL-WIDGET20 warns and names visibility as the alternative.

Two details a reviewer should look at:

• Both spellings are caught. editable: 'x' lowers to Editable, but the bracket form editable: [expr] lowers to EditableIf — and the bracket form is the one that genuinely works on input widgets, so leaving it unflagged on a button would have been the more surprising silent drop. I found the second key by dumping the parsed w.Properties, not by assuming it.
• The list is pinned. editableWidgetTypes is a hand-maintained bridge between MDL type names and Mendix's, so TestEditableWidgetTypesMatchMetamodel parses generated/metamodel and fails if that set of 11 ever changes — in either direction.

Also: the residue of fixing Bug 1

contentparams supplied where no property text carries a {N} placeholder still had nothing to attach to and was dropped without a word. MDL-WIDGET21 reports it.

Neither rule is a .fail.mdl

Both are warnings, so check exits 0 and such a fixture would report negative test unexpectedly passed — the trap the Makefile documents above check-mdl, and the one that broke mendixlabs#927's CI. They are demonstrated by a plain .mdl and pinned by unit tests, which is what that note prescribes.

Verification

• Reported script: 0 errors under mx check on 11.13 (was CE0720), with the stored parameter compared against the dynamictext control rather than just counted.
• Controls: removing the engine wiring reproduces CE0720; unhooking the rule drops all three MDL-WIDGET20 cases while the direct/input cases keep passing.
• Input widgets (textbox, textarea, checkbox, datepicker) stay clean — 8 shipped examples use editable: and none is flagged.
• 339 shipped examples scanned: the only MDL-WIDGET20/21 hit is the fixture that exists to demonstrate them.
• make check-mdl exits 0; 76 unit packages green; gofmt -l clean.

Not addressed

The def-mapped texttemplate path (BuildContext) has no parameter field, so a widget whose text template arrives through a .def.json mapping rather than as an explicit property is untouched. The reported case does not go through it, and plumbing it is a larger change — flagging it rather than leaving it to be discovered.

---

Generated by Claude Code