fix(describe): quote and escape MDL strings in one place (mendixlabs/mxcli#1006)

[ako]

Fixes mendixlabs/mxcli#1006. DESCRIBE WORKFLOW emitted single-quoted payloads without doubling the quotes inside them, so its own output was a syntax error:

targeting users xpath '[System.UserRoles = '[%UserRole_Banker%]']'
  -> line 6:48 mismatched input '[%UserRole_Banker%]' expecting ';'

The string terminates at = ', and every later statement cascades — so describe output could not be fed back to check or exec for any workflow with an XPath-targeted user task.

The reported case is one of six

The emitters wrote fmt.Sprintf("… '%s'", v): quotes in the format string, escaping (when present) as a separate statement at the call site. That's one thing to remember per site, and 6 of 23 sites didn't:

site	payload
targeting users xpath	reported
targeting groups xpath	same emitter, unreported
user task caption	Manager's review — no XPath needed
workflow-level due date	the task-level one, two functions away, does escape
outcome value ×2	Won't fix

The fix

mdlQuoted(s) returns the complete literal, quotes included, so an unescaped emit cannot be written by omission. All 23 sites now go through it; the file has zero remaining '%s' and zero remaining inline ReplaceAll.

Tests

Four new tests, all verified to fail against the original emitters:

--- FAIL: TestDescribeWorkflow_XPathUserSourceReparses
    mismatched input '[%UserRole_Banker%]' expecting ';'     <- the reported error, exactly
--- FAIL: TestDescribeWorkflow_XPathGroupSourceReparses
--- FAIL: TestDescribeWorkflow_ApostropheInCaptionAndOutcomeReparses
    line 4:29 mismatched input 's' expecting ';'
--- FAIL: TestDescribers_HaveNoHandRolledStringLiterals
    cmd_workflows.go:201, :207, :222, :247, :273, :327, :342, :345, :374, :427 …

Two deliberate choices:

• Assert the emitted MDL parses, not that it contains a particular escape. A substring assertion has to encode the very escape under test, so it can pass for the wrong reason. The harness wraps the fragment in a minimal create workflow … end workflow; and runs visitor.Build. It routes through formatWorkflowActivities rather than the per-activity formatter, because the statement terminator is appended by the caller — calling the formatter directly produces unparseable output for reasons unrelated to the bug.
• A source scan for '%s' alongside the emit tests. Emit tests only cover the positions the test constructs; the real failure mode is a new site added later. mdlQuoted carrying its own quotes is what makes that scan sound rather than a style rule.

Two sibling issues from the same reporter are separate PRs: mendixlabs/mxcli#1007 (annotations) and #1005 (jump targets).

🤖 Generated with Claude Code