fix(mappings): correct the XML-schema corpus figure, and say how it was wrong - #363
Merged
Conversation
…as wrong #259 shipped claiming no demo app contains an XML schema. It is 3 documents in 1 of 9 (OneHarness: XML_ECO, XMLRequest_Diagram, XMLRequest_DiagramId). The way the zero was produced is the part worth keeping. `grep -rl "XmlSchemas" <extracted app>` can only work for MPR **v2**, where units are files under mprcontents/. OneHarness is MPR **v1**: its units live in the SQLite Unit.Contents blob, where the type string is not greppable from the file. The grep silently answered "does any file contain this string" instead of "does any project contain this document", and returned 0 for a reason unrelated to the question. Nothing about the fix changes. Failing open on an empty list is still right — 8 of 9 apps have none — and the reader is now verified against the three REAL Studio Pro documents as well as the synthetic unit that first established the $Type and Name keys: mxcli lists them with the correct module and names. Corrected in the three code comments, the bug-test fixture, and the finding record, which also now carries the read-units-properly lesson. Refs #259 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#259 shipped claiming no demo app contains an XML schema. It is
3 documents in 1 of 9 — OneHarness:
XML_ECO,XMLRequest_Diagram,XMLRequest_DiagramId.How the zero was produced
That can only work for MPR v2, where units are files under
mprcontents/.OneHarness is MPR v1: its units live in the SQLite
Unit.Contentsblob,where the type string is not greppable from the file. The grep silently answered
"does any file contain this string" instead of "does any project contain this
document", and returned 0 for a reason unrelated to the question.
The lesson is in the finding record now: read units through
mprbson.units()orthe reader, never by grepping the extracted tree.
Nothing about the fix changes
Failing open on an empty list is still right — 8 of 9 apps have none, so an empty
list remains the ordinary case rather than evidence of a typo.
And the reader is now verified against the three real Studio Pro documents,
which is stronger than the synthetic unit that first established the
$TypeandNamekeys:Correct module, correct names, read straight out of a v1 project.
What is corrected
Three code comments (
mapping_customhandler.go,validate_mapping_sources.go,mapping_source_resolution_test.go), the bug-test fixture header, and thefinding record in
findings/sdk.jsonl.While measuring this I also took the census that motivates it — across 327
import/export mappings in the nine apps:
Docs-only plus comments; no behaviour change.
🤖 Generated with Claude Code