Skip to content

fix(executor): version-gate the four doctypes that need Mendix 11.9 - #394

Merged
ako merged 2 commits into
mainfrom
fix/doc-fixtures-version-gate
Sep 4, 2026
Merged

fix(executor): version-gate the four doctypes that need Mendix 11.9#394
ako merged 2 commits into
mainfrom
fix/doc-fixtures-version-gate

Conversation

@ako

@ako ako commented Sep 4, 2026

Copy link
Copy Markdown
Owner

The upstream nightly is red on 10.24 and 11.6.8 while 11.12, 11.13 and 11.14 are green (run 33846778362).

Cause

Four of the 29 mendixlabs#1018 documentation fixtures cover doctypes that do not exist below Mendix 11.9 — ai model, knowledge base, consumed mcp service, agent — and carried no version gate, so on an older project they failed at CREATE:

--- FAIL: TestDocumentation_SurvivesRewrite/ai_model
    create: create model requires Mendix 11.9.0+ (project is 11.6.8)

That failure says nothing about documentation carry. The doctype is simply absent — which is what a gate is for. These were the only failures in either job.

Reproduced, not reasoned about

mxbuild 11.6.0 is already cached locally and MX_BINARY pins it, giving the identical message and line in four seconds:

$ MX_BINARY=~/.mxcli/mxbuild/11.6.0/modeler/mx go test -tags integration ./mdl/executor/ -run 'TestDocumentation_SurvivesRewrite/(ai_model|agent)$'
    documentation_preserved_test.go:277: create: create model requires Mendix 11.9.0+ (project is 11.6.0)
FAIL

Both controls

Result
11.6.0 4 SKIP, the other 25 run and pass, both control tests pass
11.13.0 no skips — all four actually run and pass

The second is the one that matters: a gate that always skipped would turn the whole matrix green while testing nothing, and nothing else would notice.

Note

The minimum is carried as a version on the case rather than a boolean, so the reason is legible where the case is written, and it mirrors sdk/versions/mendix-11.yaml (agent_model, agent_knowledge_base, agent_consumed_mcp_service, agent — all min_version: 11.9.0).

Incidental but useful: every other doctype passes untouched on 10.24 and 11.6.8, so the documentation carry itself holds across all three supported majors.

Finding recorded.

🤖 Generated with Claude Code

ako and others added 2 commits September 4, 2026 11:36
The nightly is red on 10.24 and 11.6.8 while 11.12, 11.13 and 11.14 are
green. Four of the 29 mendixlabs#1018 documentation fixtures cover doctypes that do not
exist below 11.9 — ai model, knowledge base, consumed mcp service, agent —
and had no version gate, so on an older project they failed at CREATE:

    --- FAIL: TestDocumentation_SurvivesRewrite/ai_model
        create: create model requires Mendix 11.9.0+ (project is 11.6.8)

That failure says nothing about documentation carry. The doctype is simply
absent, which is what a gate is for.

Reproduced locally rather than reasoned about: mxbuild 11.6.0 is already
cached, and MX_BINARY pins it, giving the identical message and line in four
seconds. Both controls run:

  11.6.0   4 SKIP, 25 run and pass, both control tests pass
  11.13.0  no skips — all four actually run and pass

The second one is the one that matters. A gate that always skipped would turn
the whole matrix green while testing nothing, and nothing else would notice.

The minimum is carried as a version on the case rather than a boolean, so the
reason is legible where the case is written and it mirrors the registry entries
in sdk/versions/mendix-11.yaml (agent_model, agent_knowledge_base,
agent_consumed_mcp_service, agent — all min_version 11.9.0).

Every other doctype passes on 10.24 and 11.6.8 untouched, which is a useful
incidental result: the documentation carry itself holds across all three
supported majors.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Resolves the conflict GitHub reports on the findings shard. The shard is
merge=union in .gitattributes, so both appended lines are kept — but GitHub's
server-side merge does not run merge drivers, which is why it shows a conflict
the local merge does not have. Merging here does the union locally.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@ako
ako merged commit 3a6adfb into main Sep 4, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant