fix(executor): version-gate the four doctypes that need Mendix 11.9 - #394
Merged
Conversation
The nightly is red on 10.24 and 11.6.8 while 11.12, 11.13 and 11.14 are green. Four of the 29 mendixlabs#1018 documentation fixtures cover doctypes that do not exist below 11.9 — ai model, knowledge base, consumed mcp service, agent — and had no version gate, so on an older project they failed at CREATE: --- FAIL: TestDocumentation_SurvivesRewrite/ai_model create: create model requires Mendix 11.9.0+ (project is 11.6.8) That failure says nothing about documentation carry. The doctype is simply absent, which is what a gate is for. Reproduced locally rather than reasoned about: mxbuild 11.6.0 is already cached, and MX_BINARY pins it, giving the identical message and line in four seconds. Both controls run: 11.6.0 4 SKIP, 25 run and pass, both control tests pass 11.13.0 no skips — all four actually run and pass The second one is the one that matters. A gate that always skipped would turn the whole matrix green while testing nothing, and nothing else would notice. The minimum is carried as a version on the case rather than a boolean, so the reason is legible where the case is written and it mirrors the registry entries in sdk/versions/mendix-11.yaml (agent_model, agent_knowledge_base, agent_consumed_mcp_service, agent — all min_version 11.9.0). Every other doctype passes on 10.24 and 11.6.8 untouched, which is a useful incidental result: the documentation carry itself holds across all three supported majors. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Resolves the conflict GitHub reports on the findings shard. The shard is merge=union in .gitattributes, so both appended lines are kept — but GitHub's server-side merge does not run merge drivers, which is why it shows a conflict the local merge does not have. Merging here does the union locally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream nightly is red on 10.24 and 11.6.8 while 11.12, 11.13 and 11.14 are green (run 33846778362).
Cause
Four of the 29 mendixlabs#1018 documentation fixtures cover doctypes that do not exist below Mendix 11.9 — ai model, knowledge base, consumed mcp service, agent — and carried no version gate, so on an older project they failed at CREATE:
That failure says nothing about documentation carry. The doctype is simply absent — which is what a gate is for. These were the only failures in either job.
Reproduced, not reasoned about
mxbuild 11.6.0 is already cached locally and
MX_BINARYpins it, giving the identical message and line in four seconds:Both controls
The second is the one that matters: a gate that always skipped would turn the whole matrix green while testing nothing, and nothing else would notice.
Note
The minimum is carried as a version on the case rather than a boolean, so the reason is legible where the case is written, and it mirrors
sdk/versions/mendix-11.yaml(agent_model,agent_knowledge_base,agent_consumed_mcp_service,agent— allmin_version: 11.9.0).Incidental but useful: every other doctype passes untouched on 10.24 and 11.6.8, so the documentation carry itself holds across all three supported majors.
Finding recorded.
🤖 Generated with Claude Code