Fix nightly on Mendix 10.24: drop 11.x-only design property from 15b#47
Merged
Conversation
The nightly matrix (10.24 / 11.6 / 11.12) failed only on 10.24: TestMxCheck_DoctypeScripts/15b-fragment-slots-examples → CE6083 "Design property Card style is not supported by your theme" at every cardWrap container (both engines). `Card style` is an Atlas v3 (11.x) design property; the 10.x Atlas theme doesn't define it. The property sat on the shared `define fragment Card`, instantiated by every page in the file, so a --@Version gate would have to gate the whole file and lose all 10.24 coverage of the content-slot feature 15b actually demonstrates. The design property was incidental (12-styling covers design properties, gated 11.0+), so drop it and keep `class: 'card'` — Atlas card styling that works on every version. Verified: 15b passes on 10.24 AND 11.6.3 (0 errors, both engines). Also swept the doctype suite for other ungated designproperties/building-block usage — 03/12/29/31 gate theirs, 15c was already fixed (#43), and *.test.mdl files aren't run by the doctype test. fix-issue.md records the CE6083 case + the gate-vs-remove rule. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JXnEgoc2NQP1Y2TWMCMXC4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly matrix (Mendix 10.24 / 11.6 / 11.12) failed only on 10.24:
Card styleis an Atlas v3 (11.x) design property; the 10.x Atlas theme doesn't define it. Same class of nightly-only, version-specific failure as the 15c building-block fix (#43).Fix — remove, don't gate
The property sat on the shared
define fragment Card, instantiated by every page in the file, so a-- @version:gate would have to gate the whole file and lose all 10.24 coverage of the content-slot feature15bactually demonstrates. The design property was incidental (design properties are covered by12-styling-examples.mdl, gated 11.0+), so I dropped it and keptclass: 'card'— Atlas card styling that works on every Mendix version.Gate-vs-remove rule (now in
fix-issue.md): if the version-specific construct is the point of a self-contained section →-- @version:gate it (15c); if it's incidental and lives in a shared/expanded definition → remove it and use a cross-version equivalent (15b).Verification
MX_BINARY=…/10.24.19.104498): 15b passes, 0 errors, both engines.designproperties/use building block:03/12/29/31gate theirs,15cwas already fixed (Fix nightly on Mendix 10.24: version-gate the 11.x-only building block in 15c #43), and*.test.mdlfiles aren't run byTestMxCheck_DoctypeScripts. No other 10.24 landmines remain.🤖 Generated with Claude Code
Generated by Claude Code