[pull] master from openshift:master#1748
Merged
pull[bot] merged 6 commits intoakram:masterfrom Aug 7, 2024
Merged
Conversation
This reverts commit f56cefc. Removing the vsphere exclusion as it may obscure useful signal. The affected vsphere tests have not failed since this change, not even to flake.
The vertical scaling test will currently timeout on waiting for the CPMS status.readyReplicas to scale up to 4 where as in practice that may not happen. Ensuring that the cluster membership is 3 and checking that the old member has been removed is enough of a signal that vertical scaling has successfully completed
OCPBUGS-37837: vertical scaling test should not rely on CPMS replicas
This test does not accuratly capture the bug it references, the matcher would match on correct reasons to mark a mc as degraded thus giving false positives. Also the test is not needed because if the condition the test is checking for were ever to arise the install would simply fail before we ever come to this state. The bug the test references also has tests so we should be fine to remove this check since it's not providing any value. Signed-off-by: ehila <ehila@redhat.com>
TRT-1688: Revert "allow etcd log test to flake under vsphere"
OCPEDGE-1182: fix: remove un-needed test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )