feat(skills): add canonical Akua agent skill artifact#20
Open
robinbraemer wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Correct existing CLI PR 20 so the public Akua agent skill has the canonical identity and source path skills/akua/SKILL.md while preserving its substantive guidance. Keep skill package metadata name and provenance canonical, recompute its deterministic digest, align Release Please wiring, and test exact directory/frontmatter/package identity plus rejection of task-shaped public names. The final PR must contain no retired internal task identity anywhere in tracked files or PR evidence. Keep changes limited to the skill source, metadata, focused tests, and necessary version wiring; do not add README or architecture documentation, modify distribution lanes or another repository, dispatch downstream sync, merge, publish, or tag. Update only existing PR 20 and validate focused tests, full checks, deterministic packaging, exact remote head, and CI green.
What Changed
Risk Assessment
✅ Low: The prior false-positive regression has been correctly fixed by validating a matching task-shaped name/path pair against the exact canonical
akuaidentity, with no material collateral changes or remaining introduced risks found.Testing
The prior remote-head mismatch is resolved: local HEAD, PR #20’s branch, and its successful CI run all identify
8724c6cdbcd586820d188da4ce54408d4b7b51d0. Focused and full tests passed, generated CLI artifacts were current, and two independently produced skill archives were byte-identical and contained only the canonical skill and metadata; extraction confirmed exactakuaidentity, CLI-owned provenance, release version, and matching deterministic digest. Localmiseexecution was blocked only by its worktree trust guard, so the identical generation command was run directly; static analysis was not run locally per instruction, while exact-target CI successfully ran the repository’s fullmise run check.Evidence: End-to-end skill package verification
/var/folders/1y/cjgf53nj31n_dxsspqnjfjvc0000gn/T/no-mistakes-evidence/01KXAM8NHZWV2ME5E54N0QQ6R4/akua-skill-a.tar)Evidence: Exact remote head and successful CI evidence
Source: Exact remote head and successful CI evidence
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
test/agent-skill.test.ts:57- This test does not independently reject task-shaped identities: it fails only because the fixture name differs from the fixedskills/akuaparent directory. The same frontmatter would pass if validated at a matching task-shaped path. If task-shaped names must be prohibited, define that rule and test with a matching directory; otherwise rename this as another path/name drift case.🔧 Fix: Enforce canonical Akua skill identity
✅ Re-checked - no issues remain.
🔧 **Test** - 1 issue found → auto-fixed ✅
bun test test/agent-skill.test.ts test/release-please-config.test.tsbun testmise run generate:check(blocked by untrusted worktree config; no user-level trust change made)bun run generate:checkCreated twogit archivepackages fromHEAD:skills/akua, compared them byte-for-byte, extracted one, and verified installed frontmatter, package identity, provenance, version, and SHA-256Compared the initial artifact with the canonical rename and confirmed substantive guidance was unchanged apart from identity metadataScanned tracked target files and PR #20’s body for the retired internal identitygit ls-remote origin refs/heads/fm/akua-cli-skill-artifact refs/pull/20/headgh-axi pr checks 20git status --short🔧 Fix: Update PR head and restore green validation
✅ Re-checked - no issues remain.
git rev-parse HEADand target diff/scope inspection against634ad27d3c88b4df49a6959615208f80aca0ebb2bun test test/agent-skill.test.ts test/release-please-config.test.tsbun testmise run generate:check(blocked by untrusted isolated-worktree config), then equivalentbun run generate:checkCreated two packages usinggit archive --format=tar --prefix=akua/ … HEAD:skills/akuaand compared their SHA-256 valuesExtracted the package and parsedSKILL.mdfrontmatter plusskill-package.jsonwithbun -e; verified canonical identity, version, provenance, and matching content digestgit grep -n 'agent-skills-standard-following' HEAD -- .git ls-remote origin refs/heads/fm/akua-cli-skill-artifactgh-axi pr view 20 --fullandgh-axi pr checks 20gh-axi run list --workflow ci.yml --branch fm/akua-cli-skill-artifact --commit 8724c6cdbcd586820d188da4ce54408d4b7b51d0 …Finalgit status --short --untracked-files=allcleanup check✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.