Skip to content

Implement 3rd harmonic using trigonometric identity#10

Merged
akutuva21 merged 1 commit intomasterfrom
fix-3rd-harmonic-identity-1254867357569153273
Apr 13, 2026
Merged

Implement 3rd harmonic using trigonometric identity#10
akutuva21 merged 1 commit intomasterfrom
fix-3rd-harmonic-identity-1254867357569153273

Conversation

@akutuva21
Copy link
Copy Markdown
Owner

Replaced the hack/approximation in sp_fourier_synthesizer.bngl with an implementation of the 3rd harmonic based on the trigonometric identity: sin(3x) = 3*sin(x) - 4*sin^3(x). By taking the derivative, d(sin(3x))/dt = 3*cos(x)*w - 12*sin^2(x)*cos(x)*w, which corresponds in the BNGL functions to 3*ds1() - 12*s1()*s1()*ds1(). The ds3() function definition and comments were updated accordingly.


PR created automatically by Jules for task 1254867357569153273 started by @akutuva21

Updated `ds3()` in `sp_fourier_synthesizer.bngl` to use the exact derivative of the 3rd harmonic trigonometric identity instead of an approximation. Cleaned up corresponding comments.

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown
Owner Author

@akutuva21 akutuva21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in sequence. 3rd-harmonic derivative update is mathematically consistent with the stated identity and improves correctness.

@akutuva21 akutuva21 merged commit d2f9c22 into master Apr 13, 2026
1 check passed
@akutuva21 akutuva21 deleted the fix-3rd-harmonic-identity-1254867357569153273 branch April 13, 2026 15:25
akutuva21 pushed a commit that referenced this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant